Merge branch 'bwill/remove-sync-project-archival-status-to-sbom-occurrences' into 'master'

Remove `sync_project_archival_status_to_sbom_occurrences` feature flag

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/145419



Merged-by: Mehmet Emin INAC <minac@gitlab.com>
Approved-by: Mehmet Emin INAC <minac@gitlab.com>
Co-authored-by: Brian Williams <bwilliams@gitlab.com>

ee/config/feature_flags/gitlab_com_derisk/sync_project_archival_status_to_sbom_occurrences.yml

----
-name: sync_project_archival_status_to_sbom_occurrences
-feature_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/437636
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/143874
-rollout_issue_url: https://gitlab.com/gitlab-com/gl-infra/production/-/issues/17572
-milestone: '16.10'
-group: group::threat insights
-type: gitlab_com_derisk
-default_enabled: false

ee/lib/ee/gitlab/event_store.rb

@@ -63,11 +63,7 @@ def configure!(store)
                   ::Feature.enabled?(:update_vuln_reads_traversal_ids_via_event,
                     ::Group.find_by_id(event.data['group_id']), type: :gitlab_com_derisk)
                 }
-          store.subscribe ::Sbom::SyncArchivedStatusWorker, to: ::Projects::ProjectArchivedEvent,
-            if: ->(event) do
-              project = ::Project.find_by_id(event.data['project_id'])
-              ::Feature.enabled?(:sync_project_archival_status_to_sbom_occurrences, project)
-            end
+          store.subscribe ::Sbom::SyncArchivedStatusWorker, to: ::Projects::ProjectArchivedEvent
           store.subscribe ::Vulnerabilities::ProcessArchivedEventsWorker,
             to: ::Projects::ProjectArchivedEvent,
             if: ->(event) {

ee/spec/workers/sbom/sync_archived_status_worker_spec.rb

@@ -26,12 +26,4 @@
     expect { use_event }.to change { sbom_occurrence.reload.archived }.from(false).to(true)
       .and not_change { sbom_occurrence_outside_project.reload.archived }
   end
-
-  context 'when sync_project_archival_status_to_sbom_occurrences is disabled' do
-    before do
-      stub_feature_flags(sync_project_archival_status_to_sbom_occurrences: false)
-    end
-
-    it_behaves_like 'ignores the published event'
-  end
 end