Merge branch...

Merge branch 'overdue-finalize-background-migration--backfill-approval-merge-request-rule-sources-project-id' into 'master' 

Finalize migration BackfillApprovalMergeRequestRuleSourcesProjectId

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167251



Merged-by: Omar Qunsul <oqunsul@gitlab.com>
Approved-by: Omar Qunsul <oqunsul@gitlab.com>
Co-authored-by: gdk <gdk@example.com>

db/docs/batched_background_migrations/backfill_approval_merge_request_rule_sources_project_id.yml

 ---
 migration_job_name: BackfillApprovalMergeRequestRuleSourcesProjectId
-description: Backfills sharding key `approval_merge_request_rule_sources.project_id` from `approval_project_rules`.
+description: Backfills sharding key `approval_merge_request_rule_sources.project_id`
+  from `approval_project_rules`.
 feature_category: code_review_workflow
 introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/151629
 milestone: '17.0'
 queued_migration_version: 20240501044238
-finalized_by: # version of the migration that finalized this BBM
+finalized_by: '20241001231957'

db/post_migrate/20241001231957_finalize_backfill_approval_merge_request_rule_sources_project_id.rb

+# frozen_string_literal: true
+
+class FinalizeBackfillApprovalMergeRequestRuleSourcesProjectId < Gitlab::Database::Migration[2.2]
+  milestone '17.5'
+
+  disable_ddl_transaction!
+
+  restrict_gitlab_migration gitlab_schema: :gitlab_main_cell
+
+  def up
+    ensure_batched_background_migration_is_finished(
+      job_class_name: 'BackfillApprovalMergeRequestRuleSourcesProjectId',
+      table_name: :approval_merge_request_rule_sources,
+      column_name: :id,
+      job_arguments: [:project_id, :approval_project_rules, :project_id, :approval_project_rule_id],
+      finalize: true
+    )
+  end
+
+  def down; end
+end

db/schema_migrations/20241001231957

+d82d6a9807834b8c810bb3fe740817b78bc7a6de6b29972b0c186a687bdb1b90
\ No newline at end of file