Update specs for integrations API to check all modifiable fields
Previously only the event booleans were verified, but not any other attributes that were sent in the PUT request. This is a step towards fixing inconsistencies in the Integrations API, some attributes are currently not supported and skipped in the specs. This change also exposed a bug in the getters defined by `data_field`, where we'd incorrectly fallback to `properties` for falsy values. This should only be done for explicit `nil` values. Changelog: changed
显示
- app/models/concerns/integrations/has_data_fields.rb 2 个添加, 1 个删除app/models/concerns/integrations/has_data_fields.rb
- spec/models/concerns/integrations/has_data_fields_spec.rb 42 个添加, 46 个删除spec/models/concerns/integrations/has_data_fields_spec.rb
- spec/requests/api/integrations_spec.rb 34 个添加, 18 个删除spec/requests/api/integrations_spec.rb
- spec/support/shared_contexts/features/integrations/integrations_shared_context.rb 33 个添加, 3 个删除...exts/features/integrations/integrations_shared_context.rb
加载中
想要评论请 注册 或 登录