Merge branch...

Merge branch 'not_owned--chaos--cpu-spin-worker--chaos--db-spin-worker--chaos--kill-worker--chaos--leak-mem-worker--chaos--sleep-worker' into 'master' 

Change data consistency for workers maintained by not_owned

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/170350



Merged-by: Matt Kasa <mkasa@gitlab.com>
Approved-by: Andrew Newdigate <andrew@gitlab.com>
Approved-by: Matt Kasa <mkasa@gitlab.com>
Co-authored-by: Leonardo Rosa <ldarosa@gitlab.com>

.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml

@@ -9,11 +9,6 @@ SidekiqLoadBalancing/WorkerDataConsistency:
     - 'app/workers/bulk_imports/finish_batched_pipeline_worker.rb'
     - 'app/workers/bulk_imports/pipeline_batch_worker.rb'
     - 'app/workers/bulk_imports/relation_batch_export_worker.rb'
-    - 'app/workers/chaos/cpu_spin_worker.rb'
-    - 'app/workers/chaos/db_spin_worker.rb'
-    - 'app/workers/chaos/kill_worker.rb'
-    - 'app/workers/chaos/leak_mem_worker.rb'
-    - 'app/workers/chaos/sleep_worker.rb'
     - 'app/workers/chat_notification_worker.rb'
     - 'app/workers/ci/archive_traces_cron_worker.rb'
     - 'app/workers/ci/build_prepare_worker.rb'

app/workers/chaos/cpu_spin_worker.rb

@@ -4,7 +4,7 @@ module Chaos
   class CpuSpinWorker # rubocop:disable Scalability/IdempotentWorker
     include ApplicationWorker
 
-    data_consistency :always
+    data_consistency :sticky
 
     sidekiq_options retry: 3
     include ChaosQueue

app/workers/chaos/db_spin_worker.rb

@@ -4,7 +4,7 @@ module Chaos
   class DbSpinWorker # rubocop:disable Scalability/IdempotentWorker
     include ApplicationWorker
 
-    data_consistency :always
+    data_consistency :sticky
 
     sidekiq_options retry: 3
     include ChaosQueue

app/workers/chaos/kill_worker.rb

@@ -4,7 +4,7 @@ module Chaos
   class KillWorker # rubocop:disable Scalability/IdempotentWorker
     include ApplicationWorker
 
-    data_consistency :always
+    data_consistency :sticky
     include ChaosQueue
 
     sidekiq_options retry: false

app/workers/chaos/leak_mem_worker.rb

@@ -4,7 +4,7 @@ module Chaos
   class LeakMemWorker # rubocop:disable Scalability/IdempotentWorker
     include ApplicationWorker
 
-    data_consistency :always
+    data_consistency :sticky
 
     sidekiq_options retry: 3
     include ChaosQueue

app/workers/chaos/sleep_worker.rb

@@ -4,7 +4,7 @@ module Chaos
   class SleepWorker # rubocop:disable Scalability/IdempotentWorker
     include ApplicationWorker
 
-    data_consistency :always
+    data_consistency :sticky
 
     sidekiq_options retry: 3
     include ChaosQueue