Merge branch 'mmj-tidy-up' into 'master'

Use use_includes: false where necessary

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/137903



Merged-by: Vladimir Shushlin <vshushlin@gitlab.com>
Approved-by: Thong Kuah <tkuah@gitlab.com>
Approved-by: Vladimir Shushlin <vshushlin@gitlab.com>
Reviewed-by: Manoj M J <mmj@gitlab.com>
Co-authored-by: Manoj M J <mmj@gitlab.com>

app/models/commit_status.rb

@@ -86,7 +86,7 @@ class CommitStatus < Ci::ApplicationRecord
   scope :for_project_paths, -> (paths) do
     # Pluck is used to split this query. Splitting the query is required for database decomposition for `ci_*` tables.
     # https://docs.gitlab.com/ee/development/database/transaction_guidelines.html#database-decomposition-and-sharding
-    project_ids = Project.where_full_path_in(Array(paths)).pluck(:id)
+    project_ids = Project.where_full_path_in(Array(paths), use_includes: false).pluck(:id)
 
     for_project(project_ids)
   end

app/services/clusters/agents/authorizations/user_access/refresh_service.rb

@@ -59,7 +59,7 @@ def allowed_project_configurations
 
             return unless project_entries
 
-            allowed_projects.where_full_path_in(project_entries.keys).map do |project|
+            allowed_projects.where_full_path_in(project_entries.keys, use_includes: false).map do |project|
               { project_id: project.id, config: user_access_as }
             end
           end
@@ -70,7 +70,7 @@ def allowed_group_configurations
 
             return unless group_entries
 
-            allowed_groups.where_full_path_in(group_entries.keys).map do |group|
+            allowed_groups.where_full_path_in(group_entries.keys, use_includes: false).map do |group|
               { group_id: group.id, config: user_access_as }
             end
           end

lib/gitlab/cleanup/project_uploads.rb

@@ -122,7 +122,7 @@ def orphan?
 
         # rubocop: disable CodeReuse/ActiveRecord
         def project_id
-          @project_id ||= Project.where_full_path_in([full_path]).pluck(:id)
+          @project_id ||= Project.where_full_path_in([full_path], use_includes: false).pluck(:id)
         end
         # rubocop: enable CodeReuse/ActiveRecord
       end

lib/gitlab/graphql/loaders/full_path_model_loader.rb

@@ -20,8 +20,7 @@ def find
             # this logic cannot be placed in the NamespaceResolver due to N+1
             scope = scope.without_project_namespaces if scope == Namespace
             # `with_route` avoids an N+1 calculating full_path
-            scope = scope.where_full_path_in(full_paths).with_route
-              .allow_cross_joins_across_databases(url: "https://gitlab.com/gitlab-org/gitlab/-/issues/420046")
+            scope = scope.where_full_path_in(full_paths)
 
             scope.each do |model_instance|
               loader.call(model_instance.full_path.downcase, model_instance)