Fix indexer running longer than lock timeout

This MR uses newly added --timeout option to prevent
gitlab-elasticsearch-indexer processes from running longer than the lock
timeout in Gitlab::Elastic::Indexer.

Changelog: fixed
EE: true

GITLAB_ELASTICSEARCH_INDEXER_VERSION

-2.11.0
+2.12.0

ee/app/workers/elastic_commit_indexer_worker.rb

@@ -23,7 +23,7 @@ def perform(project_id, wiki = false)
     project = Project.find(project_id)
     return true unless project.use_elasticsearch?
 
-    in_lock("#{self.class.name}/#{project_id}/#{wiki}", ttl: 1.day, retries: 0) do
+    in_lock("#{self.class.name}/#{project_id}/#{wiki}", ttl: (Gitlab::Elastic::Indexer::TIMEOUT + 1.minute), retries: 0) do
       Gitlab::Elastic::Indexer.new(project, wiki: wiki).run
     end
   end

ee/lib/gitlab/elastic/indexer.rb

@@ -8,6 +8,8 @@ module Elastic
     class Indexer
       include Gitlab::Utils::StrongMemoize
 
+      TIMEOUT = 1.day.to_i
+
       Error = Class.new(StandardError)
 
       class << self
@@ -73,11 +75,13 @@ def run_indexer!(to_sha, target)
         vars = build_envvars(base_sha, to_sha, target)
         path_to_indexer = Gitlab.config.elasticsearch.indexer_path
 
+        timeout_argument = "--timeout=#{TIMEOUT}s"
+
         command =
           if index_wiki?
-            [path_to_indexer, "--blob-type=wiki_blob", "--skip-commits", "--project-path=#{project.full_path}", project.id.to_s, repository_path]
+            [path_to_indexer, timeout_argument, "--blob-type=wiki_blob", "--skip-commits", "--project-path=#{project.full_path}", project.id.to_s, repository_path]
           else
-            [path_to_indexer, "--project-path=#{project.full_path}", project.id.to_s, repository_path]
+            [path_to_indexer, timeout_argument, "--project-path=#{project.full_path}", project.id.to_s, repository_path]
           end
 
         output, status = Gitlab::Popen.popen(command, nil, vars)

ee/spec/lib/gitlab/elastic/indexer_spec.rb

@@ -92,6 +92,7 @@
         expect_popen.with(
           [
             TestEnv.indexer_bin_path,
+            "--timeout=#{Gitlab::Elastic::Indexer::TIMEOUT}s",
             "--project-path=#{project.full_path}",
             project.id.to_s,
             "#{project.repository.disk_path}.git"
@@ -213,6 +214,7 @@ def indexed_commits_for(term)
         expect_popen.with(
           [
             TestEnv.indexer_bin_path,
+            "--timeout=#{Gitlab::Elastic::Indexer::TIMEOUT}s",
             '--blob-type=wiki_blob',
             '--skip-commits',
             "--project-path=#{project.full_path}",

ee/spec/workers/elastic_commit_indexer_worker_spec.rb

@@ -37,7 +37,7 @@
 
     it 'does not run index when it is locked' do
       expect(subject).to receive(:in_lock) # Mock and don't yield
-        .with("ElasticCommitIndexerWorker/#{project.id}/false", ttl: 1.day, retries: 0)
+        .with("ElasticCommitIndexerWorker/#{project.id}/false", ttl: (Gitlab::Elastic::Indexer::TIMEOUT + 1.minute), retries: 0)
 
       expect(Gitlab::Elastic::Indexer).not_to receive(:new)