Fix pre-main-jh pipeline 2024-12-12

jh/spec/features/registrations/combined_registration_spec.rb

@@ -18,6 +18,7 @@
 
     expect(page).to have_content('Welcome to GitLab') # rubocop:disable RSpec/ExpectInHook -- need verify content
 
+    select 'Software Developer', from: 'user_onboarding_status_role'
     choose 'Just me'
     choose 'Create a new project'
     click_on 'Continue'

jh/spec/features/registrations/saas/invite_flow_spec.rb

@@ -62,7 +62,7 @@ def registers_from_invite(user:, group:)
   end
 
   def fill_in_welcome_form
-    select 'Software Developer', from: 'user_role'
+    select 'Software Developer', from: 'user_onboarding_status_role'
     select 'A different reason', from: 'user_registration_objective'
     fill_in 'Why are you signing up? (optional)', with: 'My reason'
   end

jh/spec/features/registrations/saas/standard_flow_just_me_creating_project_spec.rb

@@ -31,7 +31,7 @@
   end
 
   def fills_in_welcome_form
-    select 'Software Developer', from: 'user_role'
+    select 'Software Developer', from: 'user_onboarding_status_role'
     select 'A different reason', from: 'user_registration_objective'
     fill_in 'Why are you signing up? (optional)', with: 'My reason'
 
@@ -44,7 +44,7 @@ def expect_to_see_welcome_form
 
     page.within(welcome_form_selector) do
       expect(page).to have_content('Role')
-      expect(page).to have_field('user_role', valid: false)
+      expect(page).to have_field('user_onboarding_status_role', valid: false)
       expect(page).to have_field('user_setup_for_company_true', valid: false)
       expect(page).to have_content('I\'m signing up for GitLab because:')
       expect(page).to have_content('Who will be using GitLab?')

jh/spec/features/registrations/sign_up_with_trial_from_external_site_without_confirmation_spec.rb

@@ -32,7 +32,7 @@
 
     fill_in_sign_up_form(user)
 
-    select 'Software Developer', from: 'user_role'
+    select 'Software Developer', from: 'user_onboarding_status_role'
     choose 'My company or team'
     choose 'Create a new project'
     click_button 'Continue'

jh/spec/features/registrations/start_trial_from_external_site_without_confirmation_spec.rb

@@ -28,7 +28,7 @@
 
     fill_in_sign_up_form(user)
 
-    select 'Software Developer', from: 'user_role'
+    select 'Software Developer', from: 'user_onboarding_status_role'
     choose 'My company or team'
     click_button 'Continue'