Merge branch '439494-move-the-harbor-integration-from-operate-to-deploy' into 'master'

Move Harbor registry sidemenu entry from Operate to Deploy

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/149216



Merged-by: Eduardo Bonet <ebonet@gitlab.com>
Approved-by: Pedro Moreira da Silva <hi@pedroms.com>
Approved-by: Paul Slaughter <pslaughter@gitlab.com>
Approved-by: Eduardo Bonet <ebonet@gitlab.com>
Co-authored-by: Rahul Chanila <rchanila@gitlab.com>

doc/user/packages/harbor_container_registry/index.md

@@ -10,6 +10,8 @@ DETAILS:
 **Tier:** Free, Premium, Ultimate
 **Offering:** GitLab.com, Self-managed, GitLab Dedicated
 
+> - **Harbor Registry** [moved](https://gitlab.com/gitlab-org/gitlab/-/issues/439494) from the **Operate** menu section to **Deploy** in GitLab 17.0.
+
 You can integrate the [Harbor container registry](../../../user/project/integrations/harbor.md) into GitLab and use Harbor as the container registry for your GitLab project to store images.
 
 ## View the Harbor registry
@@ -17,7 +19,7 @@ You can integrate the [Harbor container registry](../../../user/project/integrat
 You can view the Harbor registry for a project or group.
 
 1. On the left sidebar, select **Search or go to** and find your project or group.
-1. Select **Operate > Harbor Registry**.
+1. Select **Deploy > Harbor Registry**.
 
 You can search, sort, and filter images on this page. You can share a filtered view by copying the URL from your browser.
 
@@ -34,7 +36,7 @@ To download and run a Harbor image hosted in the GitLab Harbor registry:
 
 1. Copy the link to your container image:
     1. On the left sidebar, select **Search or go to** and find your project or group.
-    1. Select **Operate > Harbor Registry** and find the image you want.
+    1. Select **Deploy > Harbor Registry** and find the image you want.
     1. Select the **Copy** icon next to the image name.
 
 1. Use the command to run the container image you want.
@@ -44,7 +46,7 @@ To download and run a Harbor image hosted in the GitLab Harbor registry:
 To view the list of tags associated with a specific artifact:
 
 1. On the left sidebar, select **Search or go to** and find your project or group.
-1. Go to **Operate > Harbor Registry**.
+1. Go to **Deploy > Harbor Registry**.
 1. Select the image name to view its artifacts.
 1. Select the artifact you want.
 
@@ -62,7 +64,7 @@ To build and push to the Harbor registry:
 To view these commands:
 
 1. On the left sidebar, select **Search or go to** and find your project or group.
-1. Select **Operate > Harbor Registry**.
+1. Select **Deploy > Harbor Registry**.
 1. Select **CLI Commands**.
 
 ## Disable the Harbor registry for a project
@@ -75,4 +77,4 @@ To remove the Harbor registry for a project:
 1. Under **Enable integration**, clear the **Active** checkbox.
 1. Select **Save changes**.
 
-The **Operate > Harbor Registry** entry is removed from the sidebar.
+The **Deploy > Harbor Registry** entry is removed from the sidebar.

ee/spec/features/groups/navbar_spec.rb

@@ -175,7 +175,7 @@
       before do
         group.update!(harbor_integration: harbor_integration)
 
-        insert_harbor_registry_nav(_('Terraform modules'))
+        insert_harbor_registry_nav
 
         visit group_path(group)
       end

ee/spec/features/projects/navbar_spec.rb

@@ -211,7 +211,7 @@
     before do
       project.update!(harbor_integration: harbor_integration)
 
-      insert_harbor_registry_nav(_('AWS'))
+      insert_harbor_registry_nav
 
       visit project_path(project)
     end

ee/spec/lib/sidebars/projects/super_sidebar_panel_spec.rb

@@ -15,6 +15,9 @@
     create(:google_cloud_platform_workload_identity_federation_integration, project: project)
   end
 
+  # required by the Harbor Registry item
+  let_it_be(:harbor_integration) { create(:harbor_integration, project: project) }
+
   let(:user) { project.first_owner }
   let(:context) do
     Sidebars::Projects::Context.new(

lib/sidebars/groups/menus/packages_registries_menu.rb

@@ -78,7 +78,7 @@ def harbor_registry_menu_item
           ::Sidebars::MenuItem.new(
             title: _('Harbor Registry'),
             link: group_harbor_repositories_path(context.group),
-            super_sidebar_parent: ::Sidebars::Groups::SuperSidebarMenus::OperationsMenu,
+            super_sidebar_parent: ::Sidebars::Groups::SuperSidebarMenus::DeployMenu,
             active_routes: { controller: 'groups/harbor/repositories' },
             item_id: :harbor_registry
           )

lib/sidebars/projects/menus/packages_registries_menu.rb

@@ -84,7 +84,7 @@ def harbor_registry_menu_item
           ::Sidebars::MenuItem.new(
             title: _('Harbor Registry'),
             link: project_harbor_repositories_path(context.project),
-            super_sidebar_parent: Sidebars::Projects::SuperSidebarMenus::OperationsMenu,
+            super_sidebar_parent: Sidebars::Projects::SuperSidebarMenus::DeployMenu,
             active_routes: { controller: 'projects/harbor/repositories' },
             item_id: :harbor_registry
           )

lib/sidebars/projects/super_sidebar_menus/deploy_menu.rb

@@ -22,6 +22,7 @@ def configure_menu_items
             :packages_registry,
             :container_registry,
             :google_artifact_registry,
+            :harbor_registry,
             :model_registry,
             :ai_agents
           ].each { |id| add_item(::Sidebars::NilMenuItem.new(item_id: id)) }

spec/features/groups/navbar_spec.rb

@@ -84,7 +84,7 @@
     before do
       group.update!(harbor_integration: harbor_integration)
 
-      insert_harbor_registry_nav(_('Terraform modules'))
+      insert_harbor_registry_nav
 
       visit group_path(group)
     end

spec/features/projects/navbar_spec.rb

@@ -71,7 +71,7 @@
     let_it_be(:harbor_integration) { create(:harbor_integration, project: project) }
 
     before do
-      insert_harbor_registry_nav(_('AWS'))
+      insert_harbor_registry_nav
 
       visit project_path(project)
     end

spec/lib/sidebars/projects/super_sidebar_menus/deploy_menu_spec.rb

@@ -20,6 +20,7 @@
       :packages_registry,
       :container_registry,
       :google_artifact_registry,
+      :harbor_registry,
       :model_registry,
       :ai_agents
     ])

spec/support/helpers/navbar_structure_helper.rb

@@ -95,10 +95,10 @@ def insert_infrastructure_registry_nav(within)
     )
   end
 
-  def insert_harbor_registry_nav(within)
+  def insert_harbor_registry_nav
     insert_after_sub_nav_item(
-      within,
-      within: _('Operate'),
+      _('Package Registry'),
+      within: _('Deploy'),
       new_sub_nav_item_name: _('Harbor Registry')
     )
   end