Make code quality badge in diff view link to modal
Instead of passing a boolean to the diff file header Pass the array of code quality issues for that file Then show those issues in a modal when the badge is clicked Using the existing code quality issue body component
显示
- app/assets/javascripts/diffs/components/diff_file.vue 3 个添加, 5 个删除app/assets/javascripts/diffs/components/diff_file.vue
- app/assets/javascripts/diffs/components/diff_file_header.vue 9 个添加, 4 个删除app/assets/javascripts/diffs/components/diff_file_header.vue
- app/assets/javascripts/reports/codequality_report/components/codequality_issue_body.vue 3 个添加, 2 个删除.../codequality_report/components/codequality_issue_body.vue
- ee/app/assets/javascripts/diffs/components/code_quality_badge.vue 58 个添加, 14 个删除...ssets/javascripts/diffs/components/code_quality_badge.vue
- ee/spec/frontend/diffs/components/code_quality_badge_spec.js 66 个添加, 0 个删除ee/spec/frontend/diffs/components/code_quality_badge_spec.js
- locale/gitlab.pot 9 个添加, 3 个删除locale/gitlab.pot
加载中
想要评论请 注册 或 登录