Merge branch 'remove-upgrade-plan-path' into 'master'

Remove gitlab_routing_helper.rb: upgrade_plan_path

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/140404



Merged-by: Kerri Miller <kerrizor@kerrizor.com>
Approved-by: James Nutt <jnutt@gitlab.com>
Approved-by: Kerri Miller <kerrizor@kerrizor.com>
Co-authored-by: Ted Tran <tedtran2019@gmail.com>

ee/app/helpers/ee/gitlab_routing_helper.rb

@@ -72,12 +72,6 @@ def project_vulnerability_path(project, vulnerability, *args)
       project_security_vulnerability_path(project, vulnerability, *args)
     end
 
-    def upgrade_plan_path(group)
-      return profile_billings_path if group.blank?
-
-      group_billings_path(group)
-    end
-
     def self.url_helper(route_name)
       define_method("#{route_name}_url") do |*args|
         path = public_send(:"#{route_name}_path", *args) # rubocop:disable GitlabSecurity/PublicSend

ee/spec/helpers/ee/gitlab_routing_helper_spec.rb

@@ -192,26 +192,6 @@
     end
   end
 
-  describe '#upgrade_plan_path' do
-    subject { upgrade_plan_path(group) }
-
-    context 'when the group is present' do
-      let(:group) { build_stubbed(:group) }
-
-      it "returns the group billing path" do
-        expect(subject).to eq(group_billings_path(group))
-      end
-    end
-
-    context 'when the group is blank' do
-      let(:group) { nil }
-
-      it "returns the profile billing path" do
-        expect(subject).to eq(profile_billings_path)
-      end
-    end
-  end
-
   describe '#vulnerability_url' do
     let_it_be(:vulnerability) { create(:vulnerability) }