Rename can_be_approved_by? to be more descriptive
`can_be_approved_by?` can be confusing since we have a policy check called :approve_merge_request and it can be called like `user.can?(:approve_merge_request, merge_request, user)`
显示
- app/models/concerns/approvable.rb 2 个添加, 2 个删除app/models/concerns/approvable.rb
- app/serializers/merge_request_noteable_entity.rb 1 个添加, 1 个删除app/serializers/merge_request_noteable_entity.rb
- app/services/merge_requests/approval_service.rb 3 个添加, 3 个删除app/services/merge_requests/approval_service.rb
- ee/app/models/approval_state.rb 1 个添加, 1 个删除ee/app/models/approval_state.rb
- ee/app/models/approval_wrapped_any_approver_rule.rb 1 个添加, 1 个删除ee/app/models/approval_wrapped_any_approver_rule.rb
- ee/app/models/concerns/ee/approvable.rb 3 个添加, 3 个删除ee/app/models/concerns/ee/approvable.rb
- ee/lib/ee/api/entities/approval_state.rb 1 个添加, 1 个删除ee/lib/ee/api/entities/approval_state.rb
- ee/spec/models/approval_state_spec.rb 70 个添加, 70 个删除ee/spec/models/approval_state_spec.rb
- ee/spec/models/approval_wrapped_any_approver_rule_spec.rb 1 个添加, 1 个删除ee/spec/models/approval_wrapped_any_approver_rule_spec.rb
- ee/spec/models/ee/approvable_spec.rb 5 个添加, 5 个删除ee/spec/models/ee/approvable_spec.rb
- lib/api/entities/merge_request_approvals.rb 1 个添加, 1 个删除lib/api/entities/merge_request_approvals.rb
- lib/api/merge_requests.rb 1 个添加, 1 个删除lib/api/merge_requests.rb
- lib/gitlab/quick_actions/merge_request_actions.rb 2 个添加, 2 个删除lib/gitlab/quick_actions/merge_request_actions.rb
- spec/models/concerns/approvable_spec.rb 4 个添加, 4 个删除spec/models/concerns/approvable_spec.rb
加载中
想要评论请 注册 或 登录