Merge branch...

Merge branch '523333-activerecord-recordnotunique-pg-uniqueviolation-error-duplicate-key-value-violates-unique' into 'master' 

Capture model experiment creation RecordNotUnique error

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/183515



Merged-by: Fred de Gier <fdegier@gitlab.com>
Approved-by: Aman Luthra <aluthra@gitlab.com>
Approved-by: Fred de Gier <fdegier@gitlab.com>
Co-authored-by: Alper Akgun <aakgun@gitlab.com>

app/services/ml/create_experiment_service.rb

@@ -15,6 +15,9 @@ def execute
       return error(experiment.errors.full_messages) unless experiment.persisted?
 
       success(experiment)
+
+    rescue ActiveRecord::RecordNotUnique => e
+      error([e.message])
     end
 
     private

spec/services/ml/create_experiment_service_spec.rb

@@ -41,5 +41,28 @@
         expect(response.message).to include("Name can't be blank")
       end
     end
+
+    context 'when a RecordNotUnique error occurs' do
+      let_it_be(:pg_error) { 'PG::UniqueViolation: ERROR: duplicate key value violates unique constraint' }
+
+      before do
+        allow_next_instance_of(::Ml::Experiment) do |experiment|
+          allow(experiment).to receive(:save).and_raise(
+            ActiveRecord::RecordNotUnique.new(pg_error)
+          )
+        end
+      end
+
+      it 'returns an error response with the exception message' do
+        response = create_experiment
+
+        expect(response).to be_error
+        expect(response.message).to include(pg_error)
+      end
+
+      it 'does not persist the experiment' do
+        expect { create_experiment }.not_to change { Ml::Experiment.count }
+      end
+    end
   end
 end