Rename to more accurate name for adding a CI connection if not present

spec/lib/gitlab/database/query_analyzers/gitlab_schemas_metrics_spec.rb

@@ -17,7 +17,7 @@
     process_sql(ActiveRecord::Base, "SELECT 1 FROM projects")
   end
 
-  context 'properly observes all queries', :mocked_ci_connection do
+  context 'properly observes all queries', :add_ci_connection do
     using RSpec::Parameterized::TableSyntax
 
     where do

spec/support/database/multiple_databases.rb

@@ -51,8 +51,9 @@ def with_reestablished_active_record_base(reconnect: true)
     end
     # rubocop:enable Database/MultipleDatabases
 
-    def with_mocked_ci_connection
+    def with_added_ci_connection
       if Gitlab::Database.has_config?(:ci)
+        # No need to add a ci: connection if we already have one
         yield
       else
         with_reestablished_active_record_base(reconnect: true) do
@@ -92,8 +93,8 @@ def establish_connection(*args)
     end
   end
 
-  config.around(:each, :mocked_ci_connection) do |example|
-    with_mocked_ci_connection do
+  config.around(:each, :add_ci_connection) do |example|
+    with_added_ci_connection do
       example.run
     end
   end

spec/support_specs/database/multiple_databases_spec.rb

@@ -57,7 +57,7 @@
     end
   end
 
-  describe '.with_mocked_ci_connection' do
+  describe '.with_added_ci_connection' do
     context 'when only a single database is setup' do
       before do
         skip_if_multiple_databases_are_setup
@@ -67,7 +67,7 @@
         main_database = current_database(ActiveRecord::Base)
         original_database = current_database(Ci::ApplicationRecord)
 
-        with_mocked_ci_connection do
+        with_added_ci_connection do
           expect(current_database(Ci::ApplicationRecord)).to eq(main_database)
         end
 
@@ -83,7 +83,7 @@
       it 'does not mock the original Ci::ApplicationRecord connection', :aggregate_failures do
         original_database = current_database(Ci::ApplicationRecord)
 
-        with_mocked_ci_connection do
+        with_added_ci_connection do
           expect(current_database(Ci::ApplicationRecord)).to eq(original_database)
         end