Mark 20240104134928 as obsolete

This migration marks the 20240104134928 ReindexAllIssues Advanced search migration as obsolete.

[Search for references to `reindex_all_issues` in code](https://gitlab.com/search?project_id=278964&scope=blobs&search=reindex_all_issues&regex=false))

At the moment, the `gitlab-housekeeper` is not always capable of removing all references so
you must check the diff and pipeline failures to confirm if there are any issues.
It is the responsibility of the assignee (picked from ~"group::global search") to push those changes to this branch.

[Read more](https://docs.gitlab.com/ee/development/search/advanced_search_migration_styleguide.html#cleaning-up-advanced-search-migrations)
about the process for marking Advanced search migrations as obsolete.

All Advanced search migrations must have had at least one
[required stop](https : // docs.gitlab.com / ee / development / database / required_stops.html)
to process the migration. Therefore we mark any Advanced search migrations added before the
last required stop as obsolete.

This change was generated by
[gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
using the Keeps::MarkOldAdvancedSearchMigrationsAsObsolete keep.

To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the
label ~"GitLab Housekeeper" and consider pinging the author of this keep.

Changelog: other
EE: true

ee/elastic/docs/20240104134928_reindex_all_issues.yml

@@ -5,6 +5,6 @@ description: Reindex issue documents to fix https://gitlab.com/gitlab-org/gitlab
 group: group::global search
 milestone: '16.8'
 introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/138299
-obsolete: false
-marked_obsolete_by_url:
-marked_obsolete_in_milestone:
+obsolete: true
+marked_obsolete_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/16599
+marked_obsolete_in_milestone: '17.5'

ee/elastic/migrate/20240104134928_reindex_all_issues.rb

@@ -18,3 +18,5 @@ def item_to_preload
     :project
   end
 end
+
+ReindexAllIssues.prepend ::Elastic::MigrationObsolete

ee/spec/elastic/migrate/20240104134928_reindex_all_issues_spec.rb

@@ -3,11 +3,6 @@
 require 'spec_helper'
 require File.expand_path('ee/elastic/migrate/20240104134928_reindex_all_issues.rb')
 
-RSpec.describe ReindexAllIssues, :elastic, feature_category: :global_search do
-  it_behaves_like 'migration reindexes all data' do
-    let(:version) { 20240104134928 }
-    let(:objects) { create_list(:issue, 3) }
-    let(:expected_throttle_delay) { 1.minute }
-    let(:expected_batch_size) { 50_000 }
-  end
+RSpec.describe ReindexAllIssues, feature_category: :global_search do
+  it_behaves_like 'a deprecated Advanced Search migration', 20240104134928
 end