Skip to content
代码片段 群组 项目
未验证 提交 a9d605f0 编辑于 作者: Paulina Sedlak-Jakubowska's avatar Paulina Sedlak-Jakubowska 提交者: GitLab
浏览文件

Rephrase DoD requirement on MR acceptance checklist

We see that the checklist is not always ticked. Those acceptance
guidelines are very important for newer contributors, but are
reviewed by experienced ones only from time to time.

Ticking the checklist does not necessarily ensure that all
the guidelines are followed. Rewording this point let us
make sure the content of the checklist is more important
that the formality of checking it.
上级 89fc3b7b
No related branches found
No related tags found
无相关合并请求
...@@ -10,6 +10,11 @@ especially important if they didn't participate in the discussion. ...@@ -10,6 +10,11 @@ especially important if they didn't participate in the discussion.
%{first_multiline_commit} %{first_multiline_commit}
## MR acceptance checklist
**Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
## Screenshots or screen recordings ## Screenshots or screen recordings
_Screenshots are required for UI changes, and strongly recommended for all other merge requests._ _Screenshots are required for UI changes, and strongly recommended for all other merge requests._
...@@ -39,12 +44,6 @@ Example below: ...@@ -39,12 +44,6 @@ Example below:
1. Click the `invite members` button. 1. Click the `invite members` button.
--> -->
## MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
* [ ] I have evaluated the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist) for this MR.
<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md --> <!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->
/assign me /assign me
...@@ -37,9 +37,8 @@ This MR can be reused to upgrade `gitlab-styles` in this project after a new ver ...@@ -37,9 +37,8 @@ This MR can be reused to upgrade `gitlab-styles` in this project after a new ver
## MR acceptance checklist ## MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability. **Please evaluate this MR against the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist).**
It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
- [ ] I have evaluated the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist) for this MR.
## After merge ## After merge
......
...@@ -231,6 +231,8 @@ Efforts to improve this are in: ...@@ -231,6 +231,8 @@ Efforts to improve this are in:
#### Acceptance checklist #### Acceptance checklist
<!-- When editing, remember to announce the change to Engineering Division -->
This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for high-impact risks to quality, performance, reliability, security, observability, and maintainability. This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for high-impact risks to quality, performance, reliability, security, observability, and maintainability.
Using checklists improves quality in software engineering. This checklist is a straightforward tool to support and bolster the skills of contributors to the GitLab codebase. Using checklists improves quality in software engineering. This checklist is a straightforward tool to support and bolster the skills of contributors to the GitLab codebase.
......
...@@ -294,7 +294,7 @@ requirements. ...@@ -294,7 +294,7 @@ requirements.
### Approval ### Approval
1. The [MR acceptance checklist](../code_review.md#acceptance-checklist) has been checked as confirmed in the MR. 1. The MR was evaluated against the [MR acceptance checklist](../code_review.md#acceptance-checklist).
1. Create an issue in the [infrastructure issue tracker](https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues) to inform the Infrastructure department when your contribution is changing default settings or introduces a new setting, if relevant. 1. Create an issue in the [infrastructure issue tracker](https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues) to inform the Infrastructure department when your contribution is changing default settings or introduces a new setting, if relevant.
1. An agreed-upon [rollout plan](https://about.gitlab.com/handbook/engineering/development/processes/rollout-plans/). 1. An agreed-upon [rollout plan](https://about.gitlab.com/handbook/engineering/development/processes/rollout-plans/).
1. Reviewed by relevant reviewers, and all concerns are addressed for Availability, Regressions, and Security. Documentation reviews should take place as soon as possible, but they should not block a merge request. 1. Reviewed by relevant reviewers, and all concerns are addressed for Availability, Regressions, and Security. Documentation reviews should take place as soon as possible, but they should not block a merge request.
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册