Skip to content
代码片段 群组 项目
未验证 提交 a4032ae6 编辑于 作者: Avielle Wolfe's avatar Avielle Wolfe 提交者: GitLab
浏览文件

Fix boolean and number input types

Boolean and number input types were not be respected by CI
interpolation. They were being cast to strings when interpolated by
`gsub`. This commit fixes that by replacing the entire node with the
input value when the interpolation block is the entire length of the
node. In other cases, we can assume that the input is being inserted
into a string, so it's safe for us to use `gsub` to cast the value to a
string and perform the insertion.

This commit also ensures that the ability to match and replace multiple
interpolation blocks in a single node is not affected. A previous
attempt to fix this bug caused an incident because it only interpolated
the first block in a node.

Changelog: fixed
Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/434826
上级 37f6663d
No related branches found
No related tags found
加载中
加载中
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册