Skip to content
代码片段 群组 项目
未验证 提交 a30d8901 编辑于 作者: Enrique Alcántara's avatar Enrique Alcántara 提交者: GitLab
浏览文件

Merge branch 'geo-admin-settings-migrate-heading' into 'master'

No related branches found
No related tags found
无相关合并请求
...@@ -3,6 +3,7 @@ import { GlLoadingIcon } from '@gitlab/ui'; ...@@ -3,6 +3,7 @@ import { GlLoadingIcon } from '@gitlab/ui';
// eslint-disable-next-line no-restricted-imports // eslint-disable-next-line no-restricted-imports
import { mapActions, mapState } from 'vuex'; import { mapActions, mapState } from 'vuex';
import { s__ } from '~/locale'; import { s__ } from '~/locale';
import PageHeading from '~/vue_shared/components/page_heading.vue';
import { VIEW_ADMIN_GEO_SETTINGS_PAGELOAD } from 'ee/geo_settings/constants'; import { VIEW_ADMIN_GEO_SETTINGS_PAGELOAD } from 'ee/geo_settings/constants';
import { InternalEvents } from '~/tracking'; import { InternalEvents } from '~/tracking';
import GeoSettingsForm from './geo_settings_form.vue'; import GeoSettingsForm from './geo_settings_form.vue';
...@@ -18,6 +19,7 @@ export default { ...@@ -18,6 +19,7 @@ export default {
components: { components: {
GlLoadingIcon, GlLoadingIcon,
GeoSettingsForm, GeoSettingsForm,
PageHeading,
}, },
mixins: [InternalEvents.mixin()], mixins: [InternalEvents.mixin()],
computed: { computed: {
...@@ -37,8 +39,11 @@ export default { ...@@ -37,8 +39,11 @@ export default {
<template> <template>
<article data-testid="geoSettingsContainer"> <article data-testid="geoSettingsContainer">
<h1 class="page-title gl-text-size-h-display">{{ $options.i18n.geoSettingsTitle }}</h1> <page-heading :heading="$options.i18n.geoSettingsTitle">
<p>{{ $options.i18n.geoSettingsSubtitle }}</p> <template #description>
{{ $options.i18n.geoSettingsSubtitle }}
</template>
</page-heading>
<gl-loading-icon v-if="isLoading" size="xl" /> <gl-loading-icon v-if="isLoading" size="xl" />
<geo-settings-form v-else /> <geo-settings-form v-else />
</article> </article>
......
...@@ -4,6 +4,7 @@ import Vue from 'vue'; ...@@ -4,6 +4,7 @@ import Vue from 'vue';
// eslint-disable-next-line no-restricted-imports // eslint-disable-next-line no-restricted-imports
import Vuex from 'vuex'; import Vuex from 'vuex';
import PageHeading from '~/vue_shared/components/page_heading.vue';
import GeoSettingsApp from 'ee/geo_settings/components/app.vue'; import GeoSettingsApp from 'ee/geo_settings/components/app.vue';
import GeoSettingsForm from 'ee/geo_settings/components/geo_settings_form.vue'; import GeoSettingsForm from 'ee/geo_settings/components/geo_settings_form.vue';
import initStore from 'ee/geo_settings/store'; import initStore from 'ee/geo_settings/store';
...@@ -23,6 +24,9 @@ describe('GeoSettingsApp', () => { ...@@ -23,6 +24,9 @@ describe('GeoSettingsApp', () => {
const createComponent = () => { const createComponent = () => {
wrapper = shallowMount(GeoSettingsApp, { wrapper = shallowMount(GeoSettingsApp, {
store, store,
stubs: {
PageHeading,
},
}); });
}; };
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册