Memoize the source_branch_exists method for a MR
Each time this will make a redis call, which is expensive if called enough times. This was an issue when serializing large diffs for a merge request. Clear the memoized source_branch_exists on MR update Clear memoized variables before proceeding with checks Issue: gitlab.com/gitlab-org/gitlab/-/issues/209786 Merge Request: gitlab.com/gitlab-org/gitlab/-/merge_requests/34516
显示
- app/models/merge_request.rb 15 个添加, 2 个删除app/models/merge_request.rb
- changelogs/unreleased/209786-improve-performance-of-diffs_batch-diffs-metadata-source-branch-ex.yml 5 个添加, 0 个删除...rmance-of-diffs_batch-diffs-metadata-source-branch-ex.yml
- spec/models/merge_request_spec.rb 53 个添加, 0 个删除spec/models/merge_request_spec.rb
- spec/services/merge_requests/conflicts/list_service_spec.rb 1 个添加, 0 个删除spec/services/merge_requests/conflicts/list_service_spec.rb
加载中
想要评论请 注册 或 登录