Service accounts can be added to LDAP-synced groups
See [425947](https://gitlab.com/gitlab-org/gitlab/-/issues/425947) for details. Allows adding service account users to groups even when LDAP sync is enabled. To do this, we make some major changes: - Add a new permission: `admin_service_account_members` ; this way we can check for group admin permissions even when those have been mostly disabled by setting the group to LDAP syncing - Switch which permission we check in the service layer when creating new `Member` objects for groups <-> service account users - Remove multiple layers of duplicative permission checking from the API and upper-level services The new permission is only valid when the `service_accounts` licensed feature is enabled. Added some additional error handling to ensure there are no changes in the API status codes or object returns. Changelog: changed EE: true
显示
- app/services/members/create_service.rb 9 个添加, 14 个删除app/services/members/create_service.rb
- app/services/members/creator_service.rb 2 个添加, 2 个删除app/services/members/creator_service.rb
- app/services/members/destroy_service.rb 6 个添加, 1 个删除app/services/members/destroy_service.rb
- doc/administration/auth/ldap/ldap-troubleshooting.md 6 个添加, 0 个删除doc/administration/auth/ldap/ldap-troubleshooting.md
- ee/app/policies/ee/group_policy.rb 5 个添加, 0 个删除ee/app/policies/ee/group_policy.rb
- ee/app/services/ee/members/destroy_service.rb 9 个添加, 0 个删除ee/app/services/ee/members/destroy_service.rb
- ee/app/services/ee/members/groups/creator_service.rb 9 个添加, 0 个删除ee/app/services/ee/members/groups/creator_service.rb
- ee/spec/policies/group_policy_spec.rb 51 个添加, 0 个删除ee/spec/policies/group_policy_spec.rb
- ee/spec/requests/api/members_spec.rb 62 个添加, 0 个删除ee/spec/requests/api/members_spec.rb
- ee/spec/services/ee/members/destroy_service_spec.rb 20 个添加, 0 个删除ee/spec/services/ee/members/destroy_service_spec.rb
- ee/spec/services/ee/members/groups/creator_service_spec.rb 22 个添加, 0 个删除ee/spec/services/ee/members/groups/creator_service_spec.rb
- lib/api/helpers/members_helpers.rb 19 个添加, 9 个删除lib/api/helpers/members_helpers.rb
- lib/api/members.rb 0 个添加, 2 个删除lib/api/members.rb
- spec/requests/api/members_spec.rb 18 个添加, 0 个删除spec/requests/api/members_spec.rb
- spec/services/members/create_service_spec.rb 14 个添加, 2 个删除spec/services/members/create_service_spec.rb
- spec/support/shared_examples/models/member_shared_examples.rb 2 个添加, 0 个删除.../support/shared_examples/models/member_shared_examples.rb
- spec/support/shared_examples/requests/api/members_shared_examples.rb 1 个添加, 1 个删除...t/shared_examples/requests/api/members_shared_examples.rb
加载中
想要评论请 注册 或 登录