Drop injects' default values

This removes default values from injected properties within the
`NotificationEmailListboxInput` component. Those were converted from
props to injects late in the initial implementation and the default
values had been preserved. However, it seems like an injected prop only
falls back to its default value if the property isn't provided at all.
If the property is provided but is `undefined`, that's used as the
prop's value, which caused an issue with the input's default value which
needs to be an empty string and not `undefined`.

Changelog: fixed

app/assets/javascripts/notifications/components/notification_email_listbox_input.vue

@@ -5,31 +5,7 @@ export default {
   components: {
     ListboxInput,
   },
-  inject: {
-    label: {
-      from: 'label',
-      default: '',
-    },
-    name: {
-      from: 'name',
-    },
-    emails: {
-      from: 'emails',
-      default: () => [],
-    },
-    emptyValueText: {
-      from: 'emptyValueText',
-      required: true,
-    },
-    value: {
-      from: 'value',
-      default: '',
-    },
-    disabled: {
-      from: 'disabled',
-      default: false,
-    },
-  },
+  inject: ['label', 'name', 'emails', 'emptyValueText', 'value', 'disabled'],
   data() {
     return {
       selected: this.value,

app/assets/javascripts/notifications/index.js

@@ -10,7 +10,7 @@ const initNotificationEmailListboxInputs = () => {
   const els = [...document.querySelectorAll('.js-notification-email-listbox-input')];
 
   els.forEach((el, index) => {
-    const { label, name, emptyValueText, value } = el.dataset;
+    const { label, name, emptyValueText, value = '' } = el.dataset;
 
     return new Vue({
       el,