Fix inconsistency in Redis performance bar stats
peek-redis resets its counters at the start of an ActionController notification (`start_processing.action_controller`), which causes it to miss some Redis queries that precede it, such as the database load balancer and Rack Attack queries. This produces inconsistencies in the performance bar between the number of calls and their durations with the actual calls in the detailed view. We fix this by getting rid of peek-redis in favor of consolidating all logic into the `RedisDetailed` view, which tracks Redis queries using `RequestStore`. This has the nice property of removing thread-specific counters as well. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64707
显示
- Gemfile 0 个添加, 1 个删除Gemfile
- Gemfile.lock 0 个添加, 6 个删除Gemfile.lock
- config/initializers/peek.rb 1 个添加, 1 个删除config/initializers/peek.rb
- lib/peek/views/redis_detailed.rb 33 个添加, 15 个删除lib/peek/views/redis_detailed.rb
- spec/lib/peek/views/redis_detailed_spec.rb 14 个添加, 11 个删除spec/lib/peek/views/redis_detailed_spec.rb
加载中
想要评论请 注册 或 登录