Skip to content
GitLab
菜单
为什么选择 GitLab
定价
联系销售
探索
为什么选择 GitLab
定价
联系销售
探索
登录
获取免费试用
主导航
搜索或转到…
项目
GitLab
管理
动态
成员
标记
计划
议题
议题看板
里程碑
迭代
需求
代码
合并请求
仓库
分支
提交
标签
仓库图
比较修订版本
代码片段
锁定的文件
构建
流水线
作业
流水线计划
测试用例
产物
部署
发布
Package registry
Container registry
模型注册表
运维
环境
Terraform 模块
监控
事件
服务台
分析
价值流分析
贡献者分析
CI/CD 分析
仓库分析
代码评审分析
议题分析
洞察
模型实验
效能分析
帮助
帮助
支持
GitLab 文档
比较 GitLab 各版本
社区论坛
为极狐GitLab 提交贡献
提交反馈
隐私声明
快捷键
?
新增功能
4
代码片段
群组
项目
显示更多面包屑
gitlab-cn
GitLab
提交
9a892ee1
未验证
提交
9a892ee1
编辑于
11 months ago
作者:
Alex Ives
提交者:
GitLab
11 months ago
浏览文件
操作
下载
补丁
差异文件
Note that new tables need fixtures
Related to:
https://gitlab.com/gitlab-org/gitlab/-/issues/451761
上级
3b639772
No related branches found
分支 包含提交
No related tags found
标签 包含提交
无相关合并请求
变更
1
隐藏空白变更内容
行内
左右并排
显示
1 个更改的文件
doc/development/database_review.md
+4
-0
4 个添加, 0 个删除
doc/development/database_review.md
有
4 个添加
和
0 个删除
doc/development/database_review.md
+
4
−
0
浏览文件 @
9a892ee1
...
@@ -212,6 +212,9 @@ Include in the MR description:
...
@@ -212,6 +212,9 @@ Include in the MR description:
-
Order columns based on the
[
Ordering Table Columns
](
database/ordering_table_columns.md
)
guidelines.
-
Order columns based on the
[
Ordering Table Columns
](
database/ordering_table_columns.md
)
guidelines.
-
Add foreign keys to any columns pointing to data in other tables, including
[
an index
](
migration_style_guide.md#adding-foreign-key-constraints
)
.
-
Add foreign keys to any columns pointing to data in other tables, including
[
an index
](
migration_style_guide.md#adding-foreign-key-constraints
)
.
-
Add indexes for fields that are used in statements such as
`WHERE`
,
`ORDER BY`
,
`GROUP BY`
, and
`JOIN`
s.
-
Add indexes for fields that are used in statements such as
`WHERE`
,
`ORDER BY`
,
`GROUP BY`
, and
`JOIN`
s.
-
New tables must be seeded by a file in
`db/fixtures/development/`
. These fixtures are also used
to ensure that
[
upgrades complete successfully
](
database/dbmigrate:multi-version-upgrade-job.md
)
,
so it's important that new tables are always populated.
-
New tables and columns are not necessarily risky, but over time some access patterns are inherently
-
New tables and columns are not necessarily risky, but over time some access patterns are inherently
difficult to scale. To identify these risky patterns in advance, we must document expectations for
difficult to scale. To identify these risky patterns in advance, we must document expectations for
access and size. Include in the MR description answers to these questions:
access and size. Include in the MR description answers to these questions:
...
@@ -278,6 +281,7 @@ to add the raw SQL query and query plan to the Merge Request description, and re
...
@@ -278,6 +281,7 @@ to add the raw SQL query and query plan to the Merge Request description, and re
-
Are the stated access patterns and volume reasonable? Do the assumptions they're based on seem sound? Do these patterns pose risks to stability?
-
Are the stated access patterns and volume reasonable? Do the assumptions they're based on seem sound? Do these patterns pose risks to stability?
-
Are the columns
[
ordered to conserve space
](
database/ordering_table_columns.md
)
?
-
Are the columns
[
ordered to conserve space
](
database/ordering_table_columns.md
)
?
-
Are there foreign keys for references to other tables?
-
Are there foreign keys for references to other tables?
-
Does the table have a fixture in
`db/fixtures/development/`
?
-
Check data migrations:
-
Check data migrations:
-
Establish a time estimate for execution on GitLab.com.
-
Establish a time estimate for execution on GitLab.com.
-
Depending on timing, data migrations can be placed on regular, post-deploy, or background migrations.
-
Depending on timing, data migrations can be placed on regular, post-deploy, or background migrations.
...
...
此差异已折叠。
点击以展开。
预览
0%
加载中
请重试
或
添加新附件
.
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
保存评论
取消
想要评论请
注册
或
登录