Merge branch 'ph/451211/removeMrReviewerRequestsChangesFlag' into 'master'

Remove mr_reviewer_requests_changes feature flag

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/160364



Merged-by: Abdul Wadood <awadood@gitlab.com>
Approved-by: Roy Liu <rliu@gitlab.com>
Approved-by: Abdul Wadood <awadood@gitlab.com>
Co-authored-by: Phil Hughes <me@iamphill.com>

doc/user/project/merge_requests/reviews/index.md

@@ -148,6 +148,7 @@ DETAILS:
 
 > - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/430728) in GitLab 16.11 [with a flag](../../../../administration/feature_flags.md) named `mr_reviewer_requests_changes`. Disabled by default.
 > - Enabled by default [on GitLab.com](https://gitlab.com/gitlab-org/gitlab/-/issues/451211) and [self-managed](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/158226) in GitLab 17.2.
+> - [Feature flag removed](https://gitlab.com/gitlab-org/gitlab/-/issues/451211) in GitLab 17.3.
 
 A reviewer [requesting changes](#submit-a-review) blocks a merge request from merging.
 When this happens, the merge request reports area shows the message

ee/app/models/ee/merge_request.rb

@@ -501,8 +501,7 @@ def notify_approvers
     end
 
     def reviewer_requests_changes_feature
-      ::Feature.enabled?(:mr_reviewer_requests_changes, project) &&
-        project.feature_available?(:requested_changes_block_merge_request)
+      project.feature_available?(:requested_changes_block_merge_request)
     end
 
     def has_changes_requested?

ee/config/feature_flags/beta/mr_reviewer_requests_changes.yml

----
-name: mr_reviewer_requests_changes
-feature_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/430728
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/146895
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/451211
-milestone: '16.11'
-group: group::code review
-type: beta
-default_enabled: true

ee/spec/services/merge_requests/mergeability/check_requested_changes_service_spec.rb

@@ -36,14 +36,6 @@
     end
   end
 
-  context 'when feature flag is disabled' do
-    before do
-      stub_feature_flags(mr_reviewer_requests_changes: false)
-    end
-
-    it { expect(result.status).to eq Gitlab::MergeRequests::Mergeability::CheckResult::INACTIVE_STATUS }
-  end
-
   context 'when license is invalid' do
     before do
       stub_licensed_features(requested_changes_block_merge_request: false)