Merge branch '473155-graphql-object-3' into 'master'

Update graphql specs in preparation of gem upgrade - part 3

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/160421



Merged-by: Michael Kozono <mkozono@gitlab.com>
Approved-by: Sam Word <sword@gitlab.com>
Approved-by: Michael Kozono <mkozono@gitlab.com>
Co-authored-by: carlad-gl <cdrago@gitlab.com>

spec/graphql/mutations/groups/update_spec.rb

@@ -2,18 +2,21 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::Groups::Update do
+RSpec.describe Mutations::Groups::Update, feature_category: :api do
+  include GraphqlHelpers
   using RSpec::Parameterized::TableSyntax
 
   let_it_be_with_reload(:group) { create(:group) }
   let_it_be(:user) { create(:user) }
 
   let(:params) { { full_path: group.full_path } }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
 
   specify { expect(described_class).to require_graphql_authorizations(:admin_group) }
 
   describe '#resolve' do
-    subject { described_class.new(object: group, context: { current_user: user }, field: nil).resolve(**params) }
+    subject { described_class.new(object: group, context: context, field: nil).resolve(**params) }
 
     shared_examples 'updating the group shared runners setting' do
       it 'updates the group shared runners setting' do

spec/graphql/mutations/incident_management/timeline_event/create_spec.rb

@@ -2,7 +2,9 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::IncidentManagement::TimelineEvent::Create do
+RSpec.describe Mutations::IncidentManagement::TimelineEvent::Create, feature_category: :api do
+  include GraphqlHelpers
+
   let_it_be(:current_user) { create(:user) }
   let_it_be(:project) { create(:project) }
   let_it_be(:incident) { create(:incident, project: project) }
@@ -11,6 +13,8 @@
   end
 
   let(:args) { { note: 'note', occurred_at: Time.current } }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: current_user }) }
 
   specify { expect(described_class).to require_graphql_authorizations(:admin_incident_management_timeline_event) }
 
@@ -147,7 +151,7 @@
 
   private
 
-  def mutation_for(project, user)
-    described_class.new(object: project, context: { current_user: user }, field: nil)
+  def mutation_for(project, _user)
+    described_class.new(object: project, context: context, field: nil)
   end
 end

spec/graphql/mutations/incident_management/timeline_event/destroy_spec.rb

@@ -2,13 +2,16 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::IncidentManagement::TimelineEvent::Destroy do
+RSpec.describe Mutations::IncidentManagement::TimelineEvent::Destroy, feature_category: :api do
+  include GraphqlHelpers
   let_it_be(:current_user) { create(:user) }
   let_it_be(:project) { create(:project) }
   let_it_be(:incident) { create(:incident, project: project) }
 
   let(:timeline_event) { create(:incident_management_timeline_event, incident: incident, project: project) }
   let(:args) { { id: timeline_event.to_global_id } }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: current_user }) }
 
   specify { expect(described_class).to require_graphql_authorizations(:admin_incident_management_timeline_event) }
 
@@ -60,7 +63,7 @@
 
   private
 
-  def mutation_for(project, user)
-    described_class.new(object: project, context: { current_user: user }, field: nil)
+  def mutation_for(project, _user)
+    described_class.new(object: project, context: context, field: nil)
   end
 end

spec/graphql/mutations/incident_management/timeline_event/promote_from_note_spec.rb

@@ -2,7 +2,8 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::IncidentManagement::TimelineEvent::PromoteFromNote do
+RSpec.describe Mutations::IncidentManagement::TimelineEvent::PromoteFromNote, feature_category: :api do
+  include GraphqlHelpers
   include NotesHelper
 
   let_it_be(:current_user) { create(:user) }
@@ -15,6 +16,8 @@
   let_it_be(:alert_comment) { create(:note, project: project, noteable: alert) }
 
   let(:args) { { note_id: comment.to_global_id.to_s } }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: current_user }) }
 
   specify { expect(described_class).to require_graphql_authorizations(:admin_incident_management_timeline_event) }
 
@@ -82,7 +85,7 @@
 
   private
 
-  def mutation_for(project, user)
-    described_class.new(object: project, context: { current_user: user }, field: nil)
+  def mutation_for(project, _user)
+    described_class.new(object: project, context: context, field: nil)
   end
 end

spec/graphql/mutations/incident_management/timeline_event/update_spec.rb

@@ -2,7 +2,9 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::IncidentManagement::TimelineEvent::Update do
+RSpec.describe Mutations::IncidentManagement::TimelineEvent::Update, feature_category: :api do
+  include GraphqlHelpers
+
   let_it_be(:developer) { create(:user) }
   let_it_be(:reporter) { create(:user) }
   let_it_be(:project) { create(:project, developers: developer, reporters: reporter) }
@@ -30,6 +32,9 @@
     }
   end
 
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: current_user }) }
+
   let(:note) { 'Updated Note' }
   let(:timeline_event_id) { GitlabSchema.id_from_object(timeline_event).to_s }
   let(:occurred_at) { 1.minute.ago }
@@ -154,7 +159,7 @@
 
   private
 
-  def mutation_for(user)
-    described_class.new(object: nil, context: { current_user: user }, field: nil)
+  def mutation_for(_user)
+    described_class.new(object: nil, context: context, field: nil)
   end
 end

spec/graphql/mutations/incident_management/timeline_event_tag/create_spec.rb

@@ -2,11 +2,14 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::IncidentManagement::TimelineEventTag::Create do
+RSpec.describe Mutations::IncidentManagement::TimelineEventTag::Create, feature_category: :api do
+  include GraphqlHelpers
   let_it_be(:current_user) { create(:user) }
   let_it_be_with_reload(:project) { create(:project, maintainers: current_user) }
 
   let(:args) { { name: 'Test tag 1' } }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: current_user }) }
 
   specify { expect(described_class).to require_graphql_authorizations(:admin_incident_management_timeline_event_tag) }
 
@@ -42,7 +45,7 @@
 
   private
 
-  def mutation_for(project, user)
-    described_class.new(object: project, context: { current_user: user }, field: nil)
+  def mutation_for(project, _user)
+    described_class.new(object: project, context: context, field: nil)
   end
 end

spec/graphql/mutations/issues/create_spec.rb

@@ -2,7 +2,9 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::Issues::Create do
+RSpec.describe Mutations::Issues::Create, feature_category: :api do
+  include GraphqlHelpers
+
   let_it_be(:project) { create(:project) }
   let_it_be(:user) { create(:user) }
   let_it_be(:assignee1) { create(:user) }
@@ -40,7 +42,9 @@
     }
   end
 
-  let(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
+  let(:mutation) { described_class.new(object: nil, context: context, field: nil) }
   let(:mutated_issue) { subject[:issue] }
 
   specify { expect(described_class).to require_graphql_authorizations(:create_issue) }

spec/graphql/mutations/issues/link_alerts_spec.rb

@@ -3,6 +3,7 @@
 require 'spec_helper'
 
 RSpec.describe Mutations::Issues::LinkAlerts, feature_category: :incident_management do
+  include GraphqlHelpers
   let_it_be(:project) { create(:project) }
   let_it_be(:guest) { create(:user, guest_of: project) }
   let_it_be(:developer) { create(:user, developer_of: project) }
@@ -10,7 +11,9 @@
   let_it_be(:alert1) { create(:alert_management_alert, project: project) }
   let_it_be(:alert2) { create(:alert_management_alert, project: project) }
 
-  let(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
+  let(:mutation) { described_class.new(object: nil, context: context, field: nil) }
 
   specify { expect(described_class).to require_graphql_authorizations(:update_issue, :admin_issue) }
 

spec/graphql/mutations/issues/move_spec.rb

@@ -2,12 +2,17 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::Issues::Move do
+RSpec.describe Mutations::Issues::Move, feature_category: :api do
+  include GraphqlHelpers
+
   let_it_be(:issue) { create(:issue) }
   let_it_be(:user) { create(:user) }
   let_it_be(:target_project) { create(:project) }
 
-  subject(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
+
+  subject(:mutation) { described_class.new(object: nil, context: context, field: nil) }
 
   describe '#resolve' do
     subject(:resolve) { mutation.resolve(project_path: issue.project.full_path, iid: issue.iid, target_project_path: target_project.full_path) }

spec/graphql/mutations/issues/set_assignees_spec.rb

@@ -2,13 +2,17 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::Issues::SetAssignees do
+RSpec.describe Mutations::Issues::SetAssignees, feature_category: :api do
+  include GraphqlHelpers
   context 'when the user does not have permissions' do
     let_it_be(:issue) { create(:issue) }
     let_it_be(:user) { create(:user) }
     let_it_be(:assignee) { create(:user) }
 
-    subject(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
+    let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+    let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
+
+    subject(:mutation) { described_class.new(object: nil, context: context, field: nil) }
 
     describe '#resolve' do
       subject do

spec/graphql/mutations/issues/set_confidential_spec.rb

@@ -2,12 +2,15 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::Issues::SetConfidential do
+RSpec.describe Mutations::Issues::SetConfidential, feature_category: :api do
+  include GraphqlHelpers
   let(:project) { create(:project, :private) }
   let(:issue) { create(:issue, project: project, assignees: [user]) }
   let(:user) { create(:user) }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
 
-  subject(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
+  subject(:mutation) { described_class.new(object: nil, context: context, field: nil) }
 
   specify { expect(described_class).to require_graphql_authorizations(:update_issue) }
 

spec/graphql/mutations/issues/set_due_date_spec.rb

@@ -2,12 +2,16 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::Issues::SetDueDate do
+RSpec.describe Mutations::Issues::SetDueDate, feature_category: :api do
+  include GraphqlHelpers
+
   let(:issue) { create(:issue, due_date: '2021-05-01') }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
 
   let_it_be(:user) { create(:user) }
 
-  subject(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
+  subject(:mutation) { described_class.new(object: nil, context: context, field: nil) }
 
   specify { expect(described_class).to require_graphql_authorizations(:update_issue) }
 

spec/graphql/mutations/issues/set_escalation_status_spec.rb

@@ -2,14 +2,18 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::Issues::SetEscalationStatus do
+RSpec.describe Mutations::Issues::SetEscalationStatus, feature_category: :api do
+  include GraphqlHelpers
+
   let_it_be(:user) { create(:user) }
   let_it_be(:project) { create(:project) }
   let_it_be(:issue, reload: true) { create(:incident, project: project) }
   let_it_be(:escalation_status, reload: true) { create(:incident_management_issuable_escalation_status, issue: issue) }
 
   let(:status) { :acknowledged }
-  let(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
+  let(:mutation) { described_class.new(object: nil, context: context, field: nil) }
 
   describe '#resolve' do
     let(:args) { { status: status } }

spec/graphql/mutations/issues/set_locked_spec.rb

@@ -2,11 +2,15 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::Issues::SetLocked do
+RSpec.describe Mutations::Issues::SetLocked, feature_category: :api do
+  include GraphqlHelpers
+
   let_it_be(:issue) { create(:issue) }
   let_it_be(:user) { create(:user) }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
 
-  subject(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
+  subject(:mutation) { described_class.new(object: nil, context: context, field: nil) }
 
   specify { expect(described_class).to require_graphql_authorizations(:update_issue) }
 

spec/graphql/mutations/issues/set_severity_spec.rb

@@ -2,13 +2,17 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::Issues::SetSeverity do
+RSpec.describe Mutations::Issues::SetSeverity, feature_category: :api do
+  include GraphqlHelpers
+
   let_it_be(:project) { create(:project) }
   let_it_be(:guest) { create(:user, guest_of: project) }
   let_it_be(:reporter) { create(:user, reporter_of: project) }
   let_it_be(:issue) { create(:incident, project: project) }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
 
-  let(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
+  let(:mutation) { described_class.new(object: nil, context: context, field: nil) }
 
   specify { expect(described_class).to require_graphql_authorizations(:update_issue, :admin_issue) }
 

spec/graphql/mutations/issues/unlink_alert_spec.rb

@@ -3,6 +3,8 @@
 require 'spec_helper'
 
 RSpec.describe Mutations::Issues::UnlinkAlert, feature_category: :incident_management do
+  include GraphqlHelpers
+
   let_it_be(:project) { create(:project) }
   let_it_be(:another_project) { create(:project) }
   let_it_be(:guest) { create(:user, guest_of: project) }
@@ -11,7 +13,9 @@
   let_it_be(:external_alert) { create(:alert_management_alert, project: another_project) }
   let_it_be(:issue) { create(:incident, project: project, alert_management_alerts: [internal_alert, external_alert]) }
 
-  let(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
+  let(:mutation) { described_class.new(object: nil, context: context, field: nil) }
 
   specify { expect(described_class).to require_graphql_authorizations(:update_issue, :admin_issue) }
 

spec/graphql/mutations/issues/update_spec.rb

@@ -3,6 +3,8 @@
 require 'spec_helper'
 
 RSpec.describe Mutations::Issues::Update, feature_category: :team_planning do
+  include GraphqlHelpers
+
   let_it_be(:project) { create(:project) }
   let_it_be(:user) { create(:user) }
   let_it_be(:project_label) { create(:label, project: project) }
@@ -20,7 +22,9 @@
     }
   end
 
-  let(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
+  let(:mutation) { described_class.new(object: nil, context: context, field: nil) }
   let(:mutated_issue) { subject[:issue] }
 
   specify { expect(described_class).to require_graphql_authorizations(:update_issue) }

spec/graphql/mutations/labels/create_spec.rb

@@ -2,7 +2,9 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::Labels::Create do
+RSpec.describe Mutations::Labels::Create, feature_category: :api do
+  include GraphqlHelpers
+
   let_it_be(:user) { create(:user) }
 
   let(:attributes) do
@@ -12,7 +14,9 @@
     }
   end
 
-  let(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
+  let(:mutation) { described_class.new(object: nil, context: context, field: nil) }
   let(:mutated_label) { subject[:label] }
 
   shared_examples 'create labels mutation' do

spec/graphql/mutations/members/bulk_update_base_spec.rb

@@ -7,9 +7,11 @@
 
   let_it_be(:user) { create(:user) }
   let_it_be(:group) { create(:group, owners: user) }
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
 
   it 'raises a NotImplementedError error if the source_type method is called on the base class' do
-    mutation = described_class.new(context: { current_user: user }, object: nil, field: nil)
+    mutation = described_class.new(context: context, object: nil, field: nil)
 
     expect { mutation.resolve(group_id: group.to_gid.to_s) }.to raise_error(NotImplementedError)
   end

spec/graphql/mutations/merge_requests/accept_spec.rb

@@ -2,21 +2,16 @@
 
 require 'spec_helper'
 
-RSpec.describe Mutations::MergeRequests::Accept do
+RSpec.describe Mutations::MergeRequests::Accept, feature_category: :api do
   include GraphqlHelpers
   include AfterNextHelpers
 
-  subject(:mutation) { described_class.new(context: context, object: nil, field: nil) }
-
   let_it_be(:user) { create(:user) }
-
   let(:project) { create(:project, :public, :repository) }
-  let(:context) do
-    GraphQL::Query::Context.new(
-      query: query_double(schema: GitlabSchema),
-      values: { current_user: user }
-    )
-  end
+  let(:query) { GraphQL::Query.new(empty_schema, document: nil, context: {}, variables: {}) }
+  let(:context) { GraphQL::Query::Context.new(query: query, values: { current_user: user }) }
+
+  subject(:mutation) { described_class.new(context: context, object: nil, field: nil) }
 
   before do
     project.repository.expire_all_method_caches