Merge branch '519333-prevent-race-conditions-when-reading-duo-availability' into 'master'

Prevent race conditions when reading duo_availability value from ApplicationSettings

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/182111



Merged-by: Sam Word <sword@gitlab.com>
Approved-by: Minahil Nichols <minahilnichols@gitlab.com>
Approved-by: Sam Word <sword@gitlab.com>
Reviewed-by: Sam Word <sword@gitlab.com>
Co-authored-by: Julie Huang <julhuang@gitlab.com>

ee/app/helpers/admin/application_settings_helper.rb

@@ -7,7 +7,7 @@ module ApplicationSettingsHelper
     delegate :duo_availability,
       :instance_level_ai_beta_features_enabled,
       :enabled_expanded_logging,
-      to: :'Gitlab::CurrentSettings.current_application_settings'
+      to: :current_application_settings
 
     def ai_powered_testing_agreement
       safe_format(
@@ -101,6 +101,13 @@ def ai_settings_helper_data
 
     private
 
+    def current_application_settings
+      # clear cached settings so that duo_availability shows up correctly
+      Gitlab::CurrentSettings.expire_current_application_settings
+
+      Gitlab::CurrentSettings.current_application_settings
+    end
+
     # rubocop:disable Gitlab/DocumentationLinks/HardcodedUrl
     # We want to link SaaS docs for flexibility for every URL related to Code Suggestions on Self Managed.
     # We expect to update docs often during the Beta and we want to point user to the most up to date information.