Remove project_ref_name_in_variables FF

Remove flag references in code

Changelog: fixed
MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/160190

app/services/ci/list_config_variables_service.rb

@@ -28,8 +28,7 @@ def calculate_reactive_cache(sha)
 
       return {} unless config.exists?
 
-      ref_name = Gitlab::Ci::RefFinder.new(project).find_by_sha(sha) if Feature.enabled?(
-        :project_ref_name_in_variables, project)
+      ref_name = Gitlab::Ci::RefFinder.new(project).find_by_sha(sha)
 
       result = Gitlab::Ci::YamlProcessor.new(
         config.content,

config/feature_flags/gitlab_com_derisk/project_ref_name_in_variables.yml

----
-name: project_ref_name_in_variables
-feature_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/430786
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/155868
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/466427
-milestone: '17.2'
-group: group::pipeline authoring
-type: gitlab_com_derisk
-default_enabled: false

spec/services/ci/list_config_variables_service_spec.rb

@@ -213,21 +213,6 @@
         expect(result['COMMON_VAR']).to eq({ value: 'include_two', description: 'Common variable' })
       end
     end
-
-    context 'when feature flag is disabled in the project' do
-      before do
-        stub_feature_flags(project_ref_name_in_variables: false)
-      end
-
-      it 'passes nil as the ref name to YamlProcessor' do
-        expect(Gitlab::Ci::YamlProcessor)
-          .to receive(:new)
-          .with(anything, a_hash_including(ref: nil))
-          .and_call_original
-
-        result
-      end
-    end
   end
 
   context 'when project CI config is external' do