Skip to content
代码片段 群组 项目
提交 94f37e86 编辑于 作者: Mikołaj Wawrzyniak's avatar Mikołaj Wawrzyniak
浏览文件

Merge branch 'add_notice_to_run_pipeline' into 'master'

Use dangers to remind user to check migrations

See merge request gitlab-org/gitlab!91439
No related branches found
No related tags found
无相关合并请求
...@@ -30,6 +30,12 @@ If you no longer require a database review, you can remove this suggestion ...@@ -30,6 +30,12 @@ If you no longer require a database review, you can remove this suggestion
by removing the ~database label and re-running the [`danger-review` job](#{ENV['CI_JOB_URL']}). by removing the ~database label and re-running the [`danger-review` job](#{ENV['CI_JOB_URL']}).
MSG MSG
DB_MIGRATION_TESTING_REQUIRED_MESSAGE = <<~MSG
1. If this is not a ~"Community contribution" or from a Fork, kick off the
`db:gitlabcom-database-testing` manual job.
MSG
DATABASE_APPROVED_LABEL = 'database::approved' DATABASE_APPROVED_LABEL = 'database::approved'
non_geo_db_schema_updated = !git.modified_files.grep(%r{\Adb/structure\.sql}).empty? non_geo_db_schema_updated = !git.modified_files.grep(%r{\Adb/structure\.sql}).empty?
...@@ -58,9 +64,10 @@ if helper.mr_labels.include?('database') || db_paths_to_review.any? ...@@ -58,9 +64,10 @@ if helper.mr_labels.include?('database') || db_paths_to_review.any?
'review from the [Database team](https://gitlab.com/groups/gl-database/-/group_members).' 'review from the [Database team](https://gitlab.com/groups/gl-database/-/group_members).'
markdown(DB_MESSAGE) markdown(DB_MESSAGE)
markdown(DB_MIGRATION_TESTING_REQUIRED_MESSAGE) if non_geo_migration_created
if db_paths_to_review.any? if db_paths_to_review.any?
markdown(DB_FILES_MESSAGE + helper.markdown_list(db_paths_to_review)) markdown(DB_FILES_MESSAGE + helper.markdown_list(db_paths_to_review.to_set))
else else
markdown(DB_REMOVE_MESSAGE) markdown(DB_REMOVE_MESSAGE)
end end
......
...@@ -26,7 +26,7 @@ module ProjectHelper ...@@ -26,7 +26,7 @@ module ProjectHelper
%r{\Adoc/.*(\.(md|png|gif|jpg|yml))\z} => :docs, %r{\Adoc/.*(\.(md|png|gif|jpg|yml))\z} => :docs,
%r{\A(CONTRIBUTING|LICENSE|MAINTENANCE|PHILOSOPHY|PROCESS|README)(\.md)?\z} => :docs, %r{\A(CONTRIBUTING|LICENSE|MAINTENANCE|PHILOSOPHY|PROCESS|README)(\.md)?\z} => :docs,
%r{\Adata/whats_new/} => :docs, %r{\Adata/whats_new/} => :docs,
%r{\Adb/docs/.yml\z} => :docs, %r{\Adb/docs/.+\.yml\z} => :docs,
%r{\Adata/deprecations/} => :none, %r{\Adata/deprecations/} => :none,
%r{\Adata/removals/} => :none, %r{\Adata/removals/} => :none,
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册