Add cop for has_many :through without disabled autoloading
Goldiloader is great, but has several issues with has_many :through relations: * https://github.com/salsify/goldiloader/issues/12 * https://github.com/salsify/goldiloader/issues/14 * https://github.com/salsify/goldiloader/issues/18 Rather than try to figure out which applies in each case, we should just do the drudge work of manually disabling autoloading for all relations of this type. We can always use regular preloading for specific cases, but this way we avoid generating invalid queries through Goldiloader's magic.
显示
- app/models/ci/pipeline.rb 1 个添加, 1 个删除app/models/ci/pipeline.rb
- app/models/ci/runner.rb 1 个添加, 1 个删除app/models/ci/runner.rb
- app/models/deploy_key.rb 1 个添加, 1 个删除app/models/deploy_key.rb
- app/models/deploy_token.rb 1 个添加, 1 个删除app/models/deploy_token.rb
- app/models/fork_network.rb 1 个添加, 1 个删除app/models/fork_network.rb
- app/models/group.rb 3 个添加, 3 个删除app/models/group.rb
- app/models/lfs_object.rb 1 个添加, 1 个删除app/models/lfs_object.rb
- app/models/milestone.rb 1 个添加, 1 个删除app/models/milestone.rb
- app/models/project.rb 11 个添加, 11 个删除app/models/project.rb
- app/models/user.rb 8 个添加, 8 个删除app/models/user.rb
- rubocop/cop/gitlab/has_many_through_scope.rb 45 个添加, 0 个删除rubocop/cop/gitlab/has_many_through_scope.rb
- rubocop/rubocop.rb 2 个添加, 1 个删除rubocop/rubocop.rb
- spec/rubocop/cop/gitlab/has_many_through_scope_spec.rb 74 个添加, 0 个删除spec/rubocop/cop/gitlab/has_many_through_scope_spec.rb
加载中
想要评论请 注册 或 登录