Skip to content
代码片段 群组 项目
提交 93ac9733 编辑于 作者: Chad Woolley's avatar Chad Woolley
浏览文件

Refactor SpamActionService and its usage

* Removes 'SpamCheckMethods' and makes spam-checking workflow
  explicit in callers
* Moves captcha verification to be encapsulated in 'SpamActionService'
* Introduces 'CaptchaVerificationService', which can be expanded upon
  on the future for additional captcha implementations.
* Moves handling of 'request' parameter to be called only where it
  is needed.
* Removes memoization of GitLab::Recaptcha.load_configurations! -
  it complicates testing/mocking, and it isn't clear why it was
  ever needed - it isn't memoized other places.
* Rewrites issue and snippet service create/update tests to remove
  tests of internal behavior of other services, and instead just
  test their collaborations via mock expectations.
* Expands and improves test coverage of SpamActionService
* Other related changes to accomodate new interface and behavior.
上级 1ae7050e
No related branches found
No related tags found
加载中
显示
442 个添加461 个删除
加载中
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册