Applied suggestions from review

spec/finders/crm/contacts_finder_spec.rb

@@ -101,18 +101,18 @@
       context 'when search term is empty' do
         it 'returns all group contacts alphabetically ordered' do
           finder = described_class.new(user, group: search_test_group, search: "")
-          expect(finder.execute).to match_array([search_test_a, search_test_b])
+          expect(finder.execute).to eq([search_test_a, search_test_b])
         end
       end
 
       context 'when search term is not empty' do
-        it 'searches for first name' do
-          finder = described_class.new(user, group: search_test_group, search: "abc")
+        it 'searches for first name ignoring casing' do
+          finder = described_class.new(user, group: search_test_group, search: "aBc")
           expect(finder.execute).to match_array([search_test_a])
         end
 
-        it 'searches for last name' do
-          finder = described_class.new(user, group: search_test_group, search: "STU")
+        it 'searches for last name ignoring casing' do
+          finder = described_class.new(user, group: search_test_group, search: "StU")
           expect(finder.execute).to match_array([search_test_b])
         end
 
@@ -121,10 +121,15 @@
           expect(finder.execute).to match_array([search_test_a])
         end
 
-        it 'searches for description' do
-          finder = described_class.new(user, group: search_test_group, search: "YZ")
+        it 'searches for description ignoring casing' do
+          finder = described_class.new(user, group: search_test_group, search: "Yz")
           expect(finder.execute).to match_array([search_test_b])
         end
+
+        it 'fuzzy searches for email and last name' do
+          finder = described_class.new(user, group: search_test_group, search: "s")
+          expect(finder.execute).to match_array([search_test_a, search_test_b])
+        end
       end
 
       context 'when searching for contacts state' do

spec/finders/crm/organizations_finder_spec.rb

@@ -95,7 +95,7 @@
       context 'when search term is empty' do
         it 'returns all group organizations alphabetically ordered' do
           finder = described_class.new(user, group: search_test_group, search: "")
-          expect(finder.execute).to match_array([search_test_b, search_test_a])
+          expect(finder.execute).to eq([search_test_b, search_test_a])
         end
       end
 

spec/graphql/resolvers/crm/contacts_resolver_spec.rb

@@ -34,16 +34,18 @@
 
   describe '#resolve' do
     context 'with unauthorized user' do
-      it 'returns no contacts' do
+      it 'does not rise an error and returns no contacts' do
+        expect { resolve_contacts(group) }.not_to raise_error
         expect(resolve_contacts(group)).to be_empty
       end
     end
 
     context 'with authorized user' do
-      it 'returns no contacts' do
-        group.add_guest(user)
+      it 'does not rise an error and returns all contacts' do
+        group.add_reporter(user)
 
         expect { resolve_contacts(group) }.not_to raise_error
+        expect(resolve_contacts(group)).to eq([contact_a, contact_b])
       end
     end
 

spec/graphql/resolvers/crm/organizations_resolver_spec.rb

@@ -28,16 +28,18 @@
 
   describe '#resolve' do
     context 'with unauthorized user' do
-      it 'returns no organizations' do
+      it 'does not rise an error and returns no organizations' do
+        expect { resolve_organizations(group) }.not_to raise_error
         expect(resolve_organizations(group)).to be_empty
       end
     end
 
     context 'with authorized user' do
-      it 'returns no organizations' do
-        group.add_guest(user)
+      it 'does not rise an error and returns all organizations' do
+        group.add_reporter(user)
 
         expect { resolve_organizations(group) }.not_to raise_error
+        expect(resolve_organizations(group)).to eq([organization_a, organization_b])
       end
     end