Merge branch '423425_remove_ff' into 'master'

Cleanup "optimize_group_template_query" feature flag

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/132525



Merged-by: Mario Celi <mcelicalderon@gitlab.com>
Approved-by: Carla Drago <cdrago@gitlab.com>
Approved-by: Jon Jenkins <jjenkins@gitlab.com>
Approved-by: Mario Celi <mcelicalderon@gitlab.com>
Reviewed-by: Vasilii Iakliushin <viakliushin@gitlab.com>
Co-authored-by: Vasilii Iakliushin <viakliushin@gitlab.com>

config/feature_flags/development/optimize_group_template_query.yml

----
-name: optimize_group_template_query
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/129399
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/422390
-milestone: '16.4'
-type: development
-group: group::source code
-default_enabled: true

ee/app/finders/groups_with_templates_finder.rb

@@ -19,7 +19,7 @@ def execute
   attr_reader :user, :group_id
 
   def extended_group_search
-    if Feature.enabled?(:optimize_group_template_query, user) && Feature.enabled?(:use_traversal_ids)
+    if Feature.enabled?(:use_traversal_ids)
       plan_ids = Plan
         .by_name(GitlabSubscriptions::Features.saas_plans_with_feature(:group_project_templates))
         .pluck(:id) # rubocop: disable CodeReuse/ActiveRecord

ee/spec/finders/groups_with_templates_finder_spec.rb

@@ -116,15 +116,5 @@
     end
   end
 
-  context 'when feature flag "optimize_group_template_query" is enabled' do
-    it_behaves_like 'groups_with_templates'
-  end
-
-  context 'when feature flag "optimize_group_template_query" is disabled' do
-    before do
-      stub_feature_flags(optimize_group_template_query: false)
-    end
-
-    it_behaves_like 'groups_with_templates'
-  end
+  it_behaves_like 'groups_with_templates'
 end