-
- 下载
Merge branch 'rs-issue-1773' into 'master'
Fix mentions not being created upon issue/merge request update New cross-references weren't being added when they were made in an issue or merge request update. This happened because the relevant `UpdateService`s were making the `notice_added_references` call after the model had already been updated and saved, so the `changes` attribute was empty and no cross-references were made at all. This fixes the bug and adds a bit of testing and a bit of refactoring. Closes #1773 See merge request !974
显示
- app/models/concerns/mentionable.rb 28 个添加, 14 个删除app/models/concerns/mentionable.rb
- app/models/note.rb 1 个添加, 1 个删除app/models/note.rb
- app/services/issues/update_service.rb 1 个添加, 1 个删除app/services/issues/update_service.rb
- app/services/merge_requests/update_service.rb 1 个添加, 1 个删除app/services/merge_requests/update_service.rb
- spec/models/concerns/mentionable_spec.rb 49 个添加, 0 个删除spec/models/concerns/mentionable_spec.rb
- spec/support/mentionable_shared_examples.rb 1 个添加, 1 个删除spec/support/mentionable_shared_examples.rb
加载中
想要评论请 注册 或 登录