Merge branch 'georgekoltsov/dont-send-emails-on-invite-dt' into 'master'

Don't send email when importing members using DirectTransfer

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/142546



Merged-by: Carla Drago <cdrago@gitlab.com>
Approved-by: James Nutt <jnutt@gitlab.com>
Approved-by: Carla Drago <cdrago@gitlab.com>
Reviewed-by: James Nutt <jnutt@gitlab.com>
Co-authored-by: George Koltsov <gkoltsov@gitlab.com>

lib/bulk_imports/common/pipelines/members_pipeline.rb

@@ -27,7 +27,9 @@ def load(_context, data)
           return if user_membership && user_membership[:access_level] >= data[:access_level]
 
           # Create new membership for any other access level
-          portable.members.create!(data)
+          member = portable.members.new(data)
+          member.importing = true # avoid sending new member notification to the invited user
+          member.save!
         end
 
         private

spec/lib/bulk_imports/common/pipelines/members_pipeline_spec.rb

@@ -87,6 +87,12 @@ def extracted_data(email:, has_next_page: false)
         expect(member.expires_at).to eq(nil)
       end
 
+      it 'does not send new member notification' do
+        expect(NotificationService).not_to receive(:new)
+
+        subject.load(context, member_data)
+      end
+
       context 'when user_id is current user id' do
         it 'does not create new membership' do
           data = { user_id: user.id }