Merge branch 'overdue-finalize-background-migration--backfill-approvals-project-id' into 'master'

Finalize migration BackfillApprovalsProjectId

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167507



Merged-by: Tiger Watson <twatson@gitlab.com>
Approved-by: Tiger Watson <twatson@gitlab.com>
Co-authored-by: gdk <gdk@example.com>

db/docs/batched_background_migrations/backfill_approvals_project_id.yml

@@ -5,4 +5,4 @@ feature_category: code_review_workflow
 introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/160035
 milestone: '17.3'
 queued_migration_version: 20240719090631
-finalized_by: # version of the migration that finalized this BBM
+finalized_by: '20241001232051'

db/post_migrate/20241001232051_finalize_backfill_approvals_project_id.rb

+# frozen_string_literal: true
+
+class FinalizeBackfillApprovalsProjectId < Gitlab::Database::Migration[2.2]
+  milestone '17.5'
+
+  disable_ddl_transaction!
+
+  restrict_gitlab_migration gitlab_schema: :gitlab_main_cell
+
+  def up
+    ensure_batched_background_migration_is_finished(
+      job_class_name: 'BackfillApprovalsProjectId',
+      table_name: :approvals,
+      column_name: :id,
+      job_arguments: [:project_id, :merge_requests, :target_project_id, :merge_request_id],
+      finalize: true
+    )
+  end
+
+  def down; end
+end

db/schema_migrations/20241001232051

+18a0a5880415bbc6d9b4376b4d5d9733d9d3c9f9b0ce44f0236edcc218e0402b
\ No newline at end of file