Merge branch 'delete-ff-usage_data_api' into 'master'

Delete the usage_data_api feature flag

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/143973



Merged-by: Hordur Freyr Yngvason <hfyngvason@gitlab.com>
Approved-by: Gavin Hinfey <ghinfey@gitlab.com>
Approved-by: Sebastian Rehm <srehm@gitlab.com>
Approved-by: Hordur Freyr Yngvason <hfyngvason@gitlab.com>
Co-authored-by: Rémy Coutable <remy@rymai.me>

config/feature_flags/ops/usage_data_api.yml

----
-name: usage_data_api
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/41301
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/267114
-milestone: '13.4'
-type: ops
-group: group::analytics instrumentation
-default_enabled: true

ee/spec/requests/api/usage_data_spec.rb

@@ -10,7 +10,6 @@
 
     context 'with authentication' do
       before do
-        stub_feature_flags(usage_data_api: true)
         stub_application_setting(usage_ping_enabled: true)
         allow(Gitlab::RequestForgeryProtection).to receive(:verified?).and_return(true)
       end
@@ -25,7 +24,6 @@
 
         before do
           stub_application_setting(usage_ping_enabled: true)
-          stub_feature_flags(usage_data_api: true)
           allow(Gitlab::RequestForgeryProtection).to receive(:verified?).and_return(true)
         end
 

lib/api/usage_data.rb

@@ -10,7 +10,6 @@ class UsageData < ::API::Base
 
     namespace 'usage_data' do
       before do
-        not_found! unless Feature.enabled?(:usage_data_api, type: :ops)
         forbidden!('Invalid CSRF token is provided') unless verified_request?
       end
 

lib/gitlab/gon_helper.rb

@@ -72,7 +72,6 @@ def add_gon_variables
 
       # Initialize gon.features with any flags that should be
       # made globally available to the frontend
-      push_frontend_feature_flag(:usage_data_api, type: :ops)
       push_frontend_feature_flag(:security_auto_fix)
       push_frontend_feature_flag(:source_editor_toolbar)
       push_frontend_feature_flag(:vscode_web_ide, current_user)

spec/requests/api/usage_data_spec.rb

@@ -8,18 +8,6 @@
   describe 'GET /usage_data/service_ping' do
     let(:endpoint) { '/usage_data/service_ping' }
 
-    context 'when feature flag is disabled' do
-      before do
-        stub_feature_flags(usage_data_api: false)
-      end
-
-      it 'returns not_found' do
-        get api(endpoint)
-
-        expect(response).to have_gitlab_http_status(:not_found)
-      end
-    end
-
     context 'without authentication' do
       it 'returns 401 response' do
         get api(endpoint)
@@ -77,7 +65,6 @@
 
     context 'without CSRF token' do
       it 'returns forbidden' do
-        stub_feature_flags(usage_data_api: true)
         allow(Gitlab::RequestForgeryProtection).to receive(:verified?).and_return(false)
 
         post api(endpoint, user), params: { event: known_event }
@@ -86,16 +73,6 @@
       end
     end
 
-    context 'usage_data_api feature not enabled' do
-      it 'returns not_found' do
-        stub_feature_flags(usage_data_api: false)
-
-        post api(endpoint, user), params: { event: known_event }
-
-        expect(response).to have_gitlab_http_status(:not_found)
-      end
-    end
-
     context 'without authentication' do
       it 'returns 401 response' do
         post api(endpoint), params: { event: known_event }
@@ -106,7 +83,6 @@
 
     context 'with authentication' do
       before do
-        stub_feature_flags(usage_data_api: true)
         stub_application_setting(usage_ping_enabled: true)
         allow(Gitlab::RequestForgeryProtection).to receive(:verified?).and_return(true)
       end
@@ -122,7 +98,7 @@
       context 'with correct params' do
         before do
           stub_application_setting(usage_ping_enabled: true)
-          stub_feature_flags(usage_data_api: true)
+
           allow(Gitlab::RequestForgeryProtection).to receive(:verified?).and_return(true)
         end
 
@@ -158,7 +134,6 @@
 
     context 'without CSRF token' do
       it 'returns forbidden' do
-        stub_feature_flags(usage_data_api: true)
         allow(Gitlab::RequestForgeryProtection).to receive(:verified?).and_return(false)
 
         post api(endpoint, user), params: { event: known_event }
@@ -167,16 +142,6 @@
       end
     end
 
-    context 'usage_data_api feature not enabled' do
-      it 'returns not_found' do
-        stub_feature_flags(usage_data_api: false)
-
-        post api(endpoint, user), params: { event: known_event }
-
-        expect(response).to have_gitlab_http_status(:not_found)
-      end
-    end
-
     context 'without authentication' do
       it 'returns 401 response' do
         post api(endpoint), params: { event: known_event }
@@ -187,7 +152,6 @@
 
     context 'with authentication' do
       before do
-        stub_feature_flags(usage_data_api: true)
         stub_application_setting(usage_ping_enabled: true)
         allow(Gitlab::RequestForgeryProtection).to receive(:verified?).and_return(true)
       end
@@ -241,16 +205,6 @@
       end
     end
 
-    context 'usage_data_api feature not enabled' do
-      it 'returns not_found' do
-        stub_feature_flags(usage_data_api: false)
-
-        post api(endpoint, user), params: { event: known_event, namespace_id: namespace_id, project_id: project_id }
-
-        expect(response).to have_gitlab_http_status(:not_found)
-      end
-    end
-
     context 'without authentication' do
       it 'returns 401 response' do
         post api(endpoint), params: { event: known_event, namespace_id: namespace_id, project_id: project_id }