Skip to content
GitLab
菜单
为什么选择 GitLab
定价
联系销售
探索
为什么选择 GitLab
定价
联系销售
探索
登录
获取免费试用
主导航
搜索或转到…
项目
GitLab
管理
动态
成员
标记
计划
议题
议题看板
里程碑
迭代
需求
代码
合并请求
仓库
分支
提交
标签
仓库图
比较修订版本
代码片段
锁定的文件
构建
流水线
作业
流水线计划
测试用例
产物
部署
发布
Package registry
Container registry
模型注册表
运维
环境
Terraform 模块
监控
事件
服务台
分析
价值流分析
贡献者分析
CI/CD 分析
仓库分析
代码评审分析
议题分析
洞察
模型实验
效能分析
帮助
帮助
支持
GitLab 文档
比较 GitLab 各版本
社区论坛
为极狐GitLab 提交贡献
提交反馈
隐私声明
快捷键
?
新增功能
4
代码片段
群组
项目
显示更多面包屑
gitlab-cn
GitLab
提交
8b36a1cb
未验证
提交
8b36a1cb
编辑于
5 months ago
作者:
Félix Veillette-Potvin
提交者:
GitLab
5 months ago
浏览文件
操作
下载
补丁
差异文件
Add the option to skip AppSec SAST bot comments
上级
69c0bcb9
No related branches found
No related tags found
无相关合并请求
变更
2
隐藏空白变更内容
行内
左右并排
显示
2 个更改的文件
scripts/semgrep_result_processor.rb
+11
-0
11 个添加, 0 个删除
scripts/semgrep_result_processor.rb
spec/scripts/semgrep_result_processor_spec.rb
+44
-0
44 个添加, 0 个删除
spec/scripts/semgrep_result_processor_spec.rb
有
55 个添加
和
0 个删除
scripts/semgrep_result_processor.rb
+
11
−
0
浏览文件 @
8b36a1cb
...
@@ -17,6 +17,7 @@ class SemgrepResultProcessor
...
@@ -17,6 +17,7 @@ class SemgrepResultProcessor
<small>
<small>
This AppSec automation is currently under testing.
This AppSec automation is currently under testing.
Use ~"appsec-sast::helpful" or ~"appsec-sast::unhelpful" for quick feedback.
Use ~"appsec-sast::helpful" or ~"appsec-sast::unhelpful" for quick feedback.
To stop the bot from further commenting, you can use the ~"appsec-sast::stop" label.
For any detailed feedback, [add a comment here](https://gitlab.com/gitlab-com/gl-security/product-security/appsec/sast-custom-rules/-/issues/38).
For any detailed feedback, [add a comment here](https://gitlab.com/gitlab-com/gl-security/product-security/appsec/sast-custom-rules/-/issues/38).
</small>
</small>
...
@@ -30,6 +31,11 @@ def execute
...
@@ -30,6 +31,11 @@ def execute
perform_allowlist_check
perform_allowlist_check
semgrep_results
=
get_sast_results
semgrep_results
=
get_sast_results
unique_results
=
filter_duplicate_findings
(
semgrep_results
)
unique_results
=
filter_duplicate_findings
(
semgrep_results
)
if
sast_stop_label_present?
puts
"Not adding comments for this MR as it has the appsec-sast::stop label. Here are the new unique findings that would have otherwise been posted:
#{
unique_results
}
"
return
end
create_inline_comments
(
unique_results
)
create_inline_comments
(
unique_results
)
rescue
StandardError
=>
e
rescue
StandardError
=>
e
...
@@ -141,6 +147,11 @@ def create_inline_comments(path_line_message_dict)
...
@@ -141,6 +147,11 @@ def create_inline_comments(path_line_message_dict)
end
end
end
end
def
sast_stop_label_present?
labels
=
ENV
[
'CI_MERGE_REQUEST_LABELS'
]
||
""
labels
.
split
(
','
).
map
(
&
:strip
).
include?
(
'appsec-sast::stop'
)
end
private
private
def
get_existing_comments
def
get_existing_comments
...
...
此差异已折叠。
点击以展开。
spec/scripts/semgrep_result_processor_spec.rb
+
44
−
0
浏览文件 @
8b36a1cb
...
@@ -53,6 +53,50 @@
...
@@ -53,6 +53,50 @@
expect
{
processor
.
execute
}.
to
raise_error
(
SystemExit
)
expect
{
processor
.
execute
}.
to
raise_error
(
SystemExit
)
end
end
context
'when CI_MERGE_REQUEST_LABELS includes appsec-sast::stop'
do
it
"prints the 'not adding comments' message"
do
stub_env
(
'CI_MERGE_REQUEST_LABELS'
,
'appsec-sast::stop'
)
expect
(
processor
).
to
receive
(
:perform_allowlist_check
)
expect
(
processor
).
to
receive
(
:get_sast_results
)
expect
(
processor
).
to
receive
(
:filter_duplicate_findings
).
with
(
sample_results
)
expect
do
processor
.
execute
end
.
to
output
(
/Not adding comments for this MR as it has the appsec-sast::stop label/
).
to_stdout
end
end
end
describe
'#sast_stop_label_present?'
do
context
'when CI_MERGE_REQUEST_LABELS includes appsec-sast::stop'
do
it
'returns true'
do
stub_env
(
'CI_MERGE_REQUEST_LABELS'
,
'appsec-sast::stop, other-label'
)
expect
(
processor
.
sast_stop_label_present?
).
to
be
true
end
end
context
'when CI_MERGE_REQUEST_LABELS does not include appsec-sast::stop'
do
it
'returns false'
do
stub_env
(
'CI_MERGE_REQUEST_LABELS'
,
'another-label, different-label'
)
expect
(
processor
.
sast_stop_label_present?
).
to
be
false
end
end
context
'when CI_MERGE_REQUEST_LABELS is empty'
do
it
'returns false'
do
stub_env
(
'CI_MERGE_REQUEST_LABELS'
,
''
)
expect
(
processor
.
sast_stop_label_present?
).
to
be
false
end
end
context
'when CI_MERGE_REQUEST_LABELS is nil'
do
it
'returns false'
do
stub_env
(
'CI_MERGE_REQUEST_LABELS'
,
nil
)
expect
(
processor
.
sast_stop_label_present?
).
to
be
false
end
end
end
end
describe
'#perform_allowlist_check'
do
describe
'#perform_allowlist_check'
do
...
...
此差异已折叠。
点击以展开。
预览
0%
加载中
请重试
或
添加新附件
.
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
保存评论
取消
想要评论请
注册
或
登录