Fix code reloading problems with custom database types
As described in https://github.com/rails/rails/issues/27337, registering a custom, autoloaded `ActiveRecord::Type` in an initializer is not safe for code reloading. Previously when `Gitlab::Database::Type::IndifferentJsonb` was registered in the ActiveRecord the registry and code reloading occurred, a `TypeError` would occur because the registry had an old reference. Let's avoid this code reloading issue by not using the ActiveRecord registry and instantiate the types explicitly. Relates to https://gitlab.com/gitlab-org/gitlab-development-kit/-/issues/2051 Changelog: fixed
显示
- app/models/application_setting.rb 1 个添加, 1 个删除app/models/application_setting.rb
- app/models/ci/build_metadata.rb 3 个添加, 3 个删除app/models/ci/build_metadata.rb
- app/models/ci/secure_file.rb 1 个添加, 1 个删除app/models/ci/secure_file.rb
- app/models/import/source_user_placeholder_reference.rb 1 个添加, 1 个删除app/models/import/source_user_placeholder_reference.rb
- app/models/merge_request_context_commit.rb 1 个添加, 1 个删除app/models/merge_request_context_commit.rb
- app/models/merge_request_diff_commit.rb 1 个添加, 1 个删除app/models/merge_request_diff_commit.rb
- app/models/plan_limits.rb 1 个添加, 1 个删除app/models/plan_limits.rb
- app/models/vulnerability.rb 1 个添加, 1 个删除app/models/vulnerability.rb
- app/models/work_items/widget_definition.rb 1 个添加, 1 个删除app/models/work_items/widget_definition.rb
- config/initializers/1_active_record_data_types.rb 0 个添加, 3 个删除config/initializers/1_active_record_data_types.rb
- doc/development/migration_style_guide.md 1 个添加, 1 个删除doc/development/migration_style_guide.md
- ee/app/models/dast/profile_schedule.rb 1 个添加, 1 个删除ee/app/models/dast/profile_schedule.rb
- ee/app/models/ee/user_detail.rb 1 个添加, 1 个删除ee/app/models/ee/user_detail.rb
- ee/app/models/search/elastic/reindexing_task.rb 1 个添加, 1 个删除ee/app/models/search/elastic/reindexing_task.rb
- ee/app/models/search/zoekt/node.rb 1 个添加, 1 个删除ee/app/models/search/zoekt/node.rb
- ee/app/models/vulnerabilities/finding.rb 1 个添加, 1 个删除ee/app/models/vulnerabilities/finding.rb
- lib/gitlab/database/type/indifferent_jsonb.rb 1 个添加, 1 个删除lib/gitlab/database/type/indifferent_jsonb.rb
- lib/gitlab/database/type/symbolized_jsonb.rb 1 个添加, 1 个删除lib/gitlab/database/type/symbolized_jsonb.rb
- spec/lib/gitlab/database/type/indifferent_jsonb_spec.rb 1 个添加, 1 个删除spec/lib/gitlab/database/type/indifferent_jsonb_spec.rb
- spec/lib/gitlab/database/type/symbolized_jsonb_spec.rb 1 个添加, 1 个删除spec/lib/gitlab/database/type/symbolized_jsonb_spec.rb
加载中
想要评论请 注册 或 登录