Merge branch '38090-remove-spinner-on-approval-change' into 'master'

Remove spinner when approval require input is changed

Closes #38090

See merge request gitlab-org/gitlab!22186

ee/app/assets/javascripts/approvals/components/app.vue

@@ -14,7 +14,6 @@ export default {
   computed: {
     ...mapState({
       settings: 'settings',
-      isLoading: state => state.approvals.isLoading,
       hasLoaded: state => state.approvals.hasLoaded,
     }),
     createModalId() {
@@ -42,7 +41,6 @@ export default {
         <slot name="rules"></slot>
       </div>
       <div v-if="settings.canEdit && settings.allowMultiRule" class="border-bottom py-3 px-2">
-        <gl-loading-icon v-if="isLoading" />
         <div v-if="settings.allowMultiRule" class="d-flex">
           <gl-button
             class="ml-auto btn-info btn-inverted"

ee/changelogs/unreleased/38090-remove-spinner-on-approval-change.yml

+---
+title: Remove spinner when approval require input is changed
+merge_request: 22186
+author:
+type: fixed

ee/spec/javascripts/approvals/components/app_spec.js

@@ -102,13 +102,6 @@ describe('EE Approvals App', () => {
         expect(findRules().exists()).toBe(true);
       });
 
-      it('shows loading icon if loading', () => {
-        store.modules.approvals.state.isLoading = true;
-        factory();
-
-        expect(findLoadingIcon().exists()).toBe(true);
-      });
-
       it('does not show loading icon if not loading', () => {
         store.modules.approvals.state.isLoading = false;
         factory();
@@ -149,14 +142,6 @@ describe('EE Approvals App', () => {
           undefined,
         );
       });
-
-      it('shows loading icon and rules if loading', () => {
-        store.modules.approvals.state.isLoading = true;
-        factory();
-
-        expect(findRules().exists()).toBe(true);
-        expect(findLoadingIcon().exists()).toBe(true);
-      });
     });
   });