Update badges on project security configuration page

Updates the badges to use neutral variant for consistency.

Changelog: changed

app/assets/javascripts/security_configuration/components/feature_card_badge.vue

@@ -26,13 +26,11 @@ export default {
       v-if="badge.tooltipText"
       placement="top"
       boundary="window"
-      title="Tooltip title"
+      :title="badge.tooltipText"
       :target="() => $refs.badge"
-    >
-      {{ badge.tooltipText }}
-    </gl-tooltip>
+    />
     <span ref="badge">
-      <gl-badge size="sm" :href="badgeHref" :variant="badge.variant">
+      <gl-badge size="sm" class="gl-cursor-pointer" :href="badgeHref" :variant="badge.variant">
         {{ badge.text }}
       </gl-badge>
     </span>

lib/gitlab/security/features.rb

@@ -31,7 +31,7 @@ def self.data
               text: _('Available on demand'),
               tooltip_text: _(
                 'On-demand scans run outside of the DevOps cycle and find vulnerabilities in your projects'),
-              variant: 'info'
+              variant: 'neutral'
             },
             secondary: {
               type: 'dast_profiles',
@@ -108,7 +108,7 @@ def self.data
               text: s_('SecurityConfiguration|Incubating feature'),
               tooltip_text: s_('SecurityConfiguration|Breach and Attack Simulation is an incubating ' \
                                'feature extending existing security testing by simulating adversary activity.'),
-              variant: 'info'
+              variant: 'neutral'
             },
             description: s_('SecurityConfiguration|Simulate breach and attack scenarios against your ' \
                             'running application by attempting to detect and exploit known vulnerabilities.'),

spec/lib/gitlab/security/scan_configuration_spec.rb

@@ -109,7 +109,7 @@
         badge: { text: "Available on demand",
                  tooltip_text: "On-demand scans run outside of the DevOps " \
                                "cycle and find vulnerabilities in your projects",
-                 variant: "info" },
+                 variant: "neutral" },
         secondary: {
           type: "dast_profiles",
           name: "DAST profiles",
@@ -163,7 +163,7 @@
                  tooltip_text: "Breach and Attack Simulation is an incubating feature " \
                                "extending existing security " \
                                "testing by simulating adversary activity.",
-                 variant: "info" },
+                 variant: "neutral" },
         description: "Simulate breach and attack scenarios against your running " \
                      "application by attempting to detect " \
                      "and exploit known vulnerabilities.",