Merge branch '463330-bubbis-link-in-math-bug' into 'master'

Ignore math on spaced_link_filter

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/182626



Merged-by: Brett Walker <bwalker@gitlab.com>
Approved-by: Brett Walker <bwalker@gitlab.com>
Reviewed-by: Brett Walker <bwalker@gitlab.com>
Co-authored-by: Samuel Suikkanen <samuel.suikkanen@hotmail.com>

lib/banzai/filter/spaced_link_filter.rb

@@ -40,7 +40,7 @@ class SpacedLinkFilter < HTML::Pipeline::Filter
       )
 
       # Text matching LINK_OR_IMAGE_PATTERN inside these elements will not be linked
-      IGNORE_PARENTS = %w[a code kbd pre script style].to_set
+      IGNORE_PARENTS = %w[a code kbd pre script style span[@data-math-style]].to_set
 
       # The XPath query to use for finding text nodes to parse.
       TEXT_QUERY = %(descendant-or-self::text()[

spec/lib/banzai/filter/spaced_link_filter_spec.rb

@@ -93,9 +93,10 @@
     expect(found_images[0]['alt']).to eq 'example'
   end
 
-  described_class::IGNORE_PARENTS.each do |elem|
-    it "ignores valid links contained inside '#{elem}' element" do
-      exp = act = "<#{elem}>See #{link}</#{elem}>"
+  described_class::IGNORE_PARENTS.each do |xpath|
+    it "ignores valid links contained inside '#{xpath}' element" do
+      match = xpath.match(/(?<element>\w+)(?:\[@(?<attribute>.*)\])?/)
+      exp = act = "<#{match[:element]}#{" #{match[:attribute]}" if match[:attribute]}>See #{link}</#{match[:element]}>"
 
       expect(filter(act).to_html).to eq exp
     end

spec/lib/banzai/pipeline/full_pipeline_spec.rb

@@ -315,4 +315,17 @@
       is_expected.to include '<span class="kc">true</span>'
     end
   end
+
+  describe 'math does not get rendered as link' do
+    [
+      "$[(a+b)c](d+e)$",
+      '$$[(a+b)c](d+e)$$',
+      '$`[(a+b)c](d+e)`$'
+    ].each do |input|
+      it "when using '#{input}' as input" do
+        result = described_class.call(input, project: nil)[:output]
+        expect(result.css('a').first).to be_nil
+      end
+    end
+  end
 end