Merge branch '489744-use-vuex-ff-helper' into 'master'

Store VSA feature flag in the Vuex store

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167646



Merged-by: Savas Vedova <svedova@gitlab.com>
Approved-by: Lukas Wanko <lwanko@gitlab.com>
Approved-by: Savas Vedova <svedova@gitlab.com>
Reviewed-by: Alex Pennells <apennells@gitlab.com>
Co-authored-by: Alex Pennells <apennells@gitlab.com>

app/assets/javascripts/analytics/shared/utils.js

@@ -149,5 +149,5 @@ export const extractVSAFeaturesFromGON = () => ({
   cycleAnalyticsForProjects: Boolean(gon?.licensed_features?.cycleAnalyticsForProjects),
   groupLevelAnalyticsDashboard: Boolean(gon?.licensed_features?.groupLevelAnalyticsDashboard),
   // feature flags
-  vsaGroupAndProjectParity: Boolean(gon?.features?.vsaGroupAndProjectParity),
+  vsaStandaloneSettingsPage: Boolean(gon?.features?.vsaStandaloneSettingsPage),
 });

ee/app/assets/javascripts/analytics/cycle_analytics/store/actions/value_streams.js

@@ -25,7 +25,7 @@ export const createValueStream = ({ commit, dispatch, getters }, data) => {
 };
 
 export const updateValueStream = (
-  { commit, dispatch, getters },
+  { state, commit, dispatch, getters },
   { id: valueStreamId, ...data },
 ) => {
   const { namespacePath } = getters;
@@ -33,7 +33,7 @@ export const updateValueStream = (
 
   return apiUpdateValueStream({ namespacePath, valueStreamId, data })
     .then(({ data: newValueStream }) => {
-      if (!gon.features?.vsaStandaloneSettingsPage) {
+      if (!state.features.vsaStandaloneSettingsPage) {
         commit(types.RECEIVE_UPDATE_VALUE_STREAM_SUCCESS, newValueStream);
         return dispatch('fetchCycleAnalyticsData');
       }

ee/spec/frontend/analytics/cycle_analytics/store/actions/value_streams_spec.js

@@ -158,13 +158,9 @@ describe('Value Stream Analytics actions / value streams', () => {
     };
     const updateResp = { id: 'new value stream', is_custom: true, ...payload };
 
-    beforeEach(() => {
-      state = { currentGroup };
-    });
-
     describe('with no errors', () => {
       beforeEach(() => {
-        window.gon = { features: { vsaStandaloneSettingsPage: true } };
+        state = { currentGroup, features: { vsaStandaloneSettingsPage: true } };
         mock.onPut(endpoints.valueStreamData).replyOnce(HTTP_STATUS_OK, updateResp);
       });
 
@@ -177,7 +173,7 @@ describe('Value Stream Analytics actions / value streams', () => {
 
       describe('when `vsaStandaloneSettingsPage` feature flag is disabled', () => {
         beforeEach(() => {
-          window.gon = { features: { vsaStandaloneSettingsPage: false } };
+          state = { currentGroup, features: { vsaStandaloneSettingsPage: false } };
         });
 
         it(`commits the ${types.REQUEST_UPDATE_VALUE_STREAM} and ${types.RECEIVE_UPDATE_VALUE_STREAM_SUCCESS} mutations and dispatches the 'fetchCycleAnalyticsData' action`, () => {