Merge branch...

Merge branch '426394-feature-flag-remove-group_vulnerabilities_optimized_query-feature-flag' into 'master' 

[Feature flag] Remove `group_vulnerabilities_optimized_query` FF

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/138308



Merged-by: Allen Cook <acook@gitlab.com>
Approved-by: Alex Buijs <abuijs@gitlab.com>
Approved-by: Allen Cook <acook@gitlab.com>
Co-authored-by: Michael Becker <11881043-wandering_person@users.noreply.gitlab.com>

ee/app/services/vulnerability_exports/export_service.rb

@@ -56,7 +56,7 @@ def exporter
     end
 
     def vulnerabilities
-      if exportable.is_a?(Group) && ::Feature.enabled?(:group_vulnerabilities_optimized_query, exportable)
+      if exportable.is_a?(Group)
         scope = ::Vulnerability.unscoped # rubocop:disable CodeReuse/ActiveRecord
 
         opts = {

ee/config/feature_flags/development/group_vulnerabilities_optimized_query.yml

----
-name: group_vulnerabilities_optimized_query
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/127180
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/426394
-milestone: '16.5'
-type: development
-group: group::threat insights
-default_enabled: false

ee/spec/services/vulnerability_exports/export_service_spec.rb

@@ -137,17 +137,6 @@
 
             expect(rows.count).to eq(group.vulnerabilities.without_archived_projects.count)
           end
-
-          context 'when group_vulnerabilities_optimized_query is disabled' do
-            before do
-              stub_feature_flags(group_vulnerabilities_optimized_query: false)
-            end
-
-            it 'delegates vulnerability lookup to the finder' do
-              export
-              expect(mock_vulnerability_finder_service_object).to have_received(:execute)
-            end
-          end
         end
       end
     end