Skip to content
代码片段 群组 项目
未验证 提交 7e1286ec 编辑于 作者: Terri Chu's avatar Terri Chu 提交者: GitLab
浏览文件

Mark 20230628094700 as obsolete

This migration marks the 20230628094700 BackfillArchivedOnIssues Advanced search migration as obsolete.

This MR will still need changes to remove [references to the migration](https://gitlab.com/search?project_id=278964&scope=blobs&search=backfill_archived_on_issues&regex=false)
in the code. At the moment, the `gitlab-housekeeper` is not always capable of removing all references so
you must check the diff and pipeline failures to confirm if there are any issues.
It is the responsibility of the assignee (picked from ~"group::global search") to push those changes to this branch.

You can read more about the process for marking Advanced search migrations as obsolete in
https://docs.gitlab.com/ee/development/search/advanced_search_migration_styleguide.html#deleting-advanced-search-migrations-in-a-major-version-upgrade.

As part of our process we want to ensure all Advanced search migrations have had at least one
[required stop](https://docs.gitlab.com/ee/development/database/required_stops.html)
to process the migration. Therefore we can mark any Advanced search migrations added before the
last required stop as obsolete.

This change was generated by
[gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
using the Keeps::MarkOldAdvancedSearchMigrationsAsObsolete keep.

To provide feedback on your experience with `gitlab-housekeeper` please comment in
<https://gitlab.com/gitlab-org/gitlab/-/issues/442003>.

Changelog: other
EE: true
上级 df78a1a7
No related branches found
No related tags found
无相关合并请求
...@@ -5,6 +5,6 @@ description: BackfillArchivedOnIssues ...@@ -5,6 +5,6 @@ description: BackfillArchivedOnIssues
group: group::global search group: group::global search
milestone: '16.2' milestone: '16.2'
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/124846 introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/124846
obsolete: false obsolete: true
marked_obsolete_by_url: marked_obsolete_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/157368
marked_obsolete_in_milestone: marked_obsolete_in_milestone: '17.2'
...@@ -16,3 +16,5 @@ def field_name ...@@ -16,3 +16,5 @@ def field_name
'archived' 'archived'
end end
end end
BackfillArchivedOnIssues.prepend ::Elastic::MigrationObsolete
...@@ -3,20 +3,6 @@ ...@@ -3,20 +3,6 @@
require 'spec_helper' require 'spec_helper'
require File.expand_path('ee/elastic/migrate/20230628094700_backfill_archived_on_issues.rb') require File.expand_path('ee/elastic/migrate/20230628094700_backfill_archived_on_issues.rb')
RSpec.describe BackfillArchivedOnIssues, :elastic_delete_by_query, :sidekiq_inline, feature_category: :global_search do RSpec.describe BackfillArchivedOnIssues, feature_category: :global_search do
let(:version) { 20230628094700 } it_behaves_like 'a deprecated Advanced Search migration', 20230628094700
include_examples 'migration backfills fields' do
let_it_be(:project) { create(:project, archived: true) }
let(:objects) { create_list(:issue, 3, project: project) }
let(:namespace) { project.namespace }
let(:expected_fields) do
{
archived: project.archived?
}
end
let(:expected_throttle_delay) { 1.minute }
let(:expected_batch_size) { 9000 }
end
end end
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册