Merge branch 'log-v2-error-message-and-origin' into 'master'

Add response server in step executor error log

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168010



Merged-by: Furkan Ayhan <furkanayhn@gmail.com>
Approved-by: Tetiana Chupryna <tchupryna@gitlab.com>
Approved-by: Furkan Ayhan <furkanayhn@gmail.com>
Co-authored-by: Shinya Maeda <shinya@gitlab.com>

ee/lib/gitlab/duo/chat/step_executor.rb

@@ -124,8 +124,16 @@ def perform_agent_request(params)
             return
           end
 
-          log_error(message: "Received error from Duo Chat Agent", event_name: 'error_returned',
-            ai_component: 'duo_chat', status: response.code)
+          # Requests could fail at intermediate servers between GitLab-Sidekiq and AI Gateway.
+          # Here are the list of servers that could intervene:
+          # - Cloud Connector Cloud Flare
+          # - GCP Cloud Run ingress / autoscaler
+          # See https://gitlab.com/groups/gitlab-org/-/epics/15402 for more information.
+          log_error(message: "Failed to request to v2/chat/agent",
+            event_name: 'error_returned',
+            ai_component: 'duo_chat',
+            status: response.code,
+            ai_response_server: response.headers['server'])
 
           # TODO: Improve error handling
           raise Gitlab::AiGateway::ForbiddenError if response.forbidden?

ee/spec/lib/gitlab/duo/chat/step_executor_spec.rb

@@ -15,7 +15,7 @@
       }
     end
 
-    let(:response) { instance_double(HTTParty::Response) }
+    let(:response) { instance_double(HTTParty::Response, headers: {}) }
 
     before do
       allow(response).to receive(:success?).and_return(true)