Merge branch '383564-remove-one-seat-requirement' into 'master'

Remove seats requirement for Advanced Search

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/139156



Merged-by: Madelein van Niekerk <mvanniekerk@gitlab.com>
Approved-by: Madelein van Niekerk <mvanniekerk@gitlab.com>
Reviewed-by: Terri Chu <tchu@gitlab.com>
Co-authored-by: Terri Chu <tchu@gitlab.com>
Co-authored-by: Dmitry Gruzd <dgruzd@gitlab.com>

ee/app/models/gitlab_subscription.rb

@@ -157,9 +157,8 @@ def automatically_index_in_elasticsearch?
     return false unless ::Gitlab.com?
     return false if expired?
 
-    # We only index paid groups on dot com for now.
-    # If the namespace is in trial, seats will be ignored.
-    Plan::PAID_HOSTED_PLANS.include?(plan_name) && (trial? || seats > 0)
+    # We only index paid groups or trials on dot com for now.
+    Plan::PAID_HOSTED_PLANS.include?(plan_name)
   end
 
   # Kick off Elasticsearch indexing for paid groups with new or upgraded paid, hosted subscriptions

ee/spec/models/gitlab_subscription_spec.rb

@@ -499,8 +499,8 @@
         context 'when seats is 0' do
           let(:gitlab_subscription) { build(:gitlab_subscription, namespace: namespace, seats: 0) }
 
-          it 'does not index the namespace' do
-            expect(ElasticsearchIndexedNamespace).not_to receive(:safe_find_or_create_by!)
+          it 'indexes the namespace' do
+            expect(ElasticsearchIndexedNamespace).to receive(:safe_find_or_create_by!).with(namespace_id: gitlab_subscription.namespace_id)
 
             gitlab_subscription.save!
           end