Skip to content
代码片段 群组 项目
提交 7a4cb742 编辑于 作者: Grzegorz Bizon's avatar Grzegorz Bizon
浏览文件

Copy-edit changes to rate limiting blueprint

上级 b44d9bff
No related branches found
No related tags found
无相关合并请求
...@@ -216,15 +216,15 @@ We should, however, avoid the possible negative-feedback-loop, that will put ...@@ -216,15 +216,15 @@ We should, however, avoid the possible negative-feedback-loop, that will put
additional strain on the Rails application when there is a sudden increase in additional strain on the Rails application when there is a sudden increase in
usage happening. This might be a big customer starting a new automation that usage happening. This might be a big customer starting a new automation that
traverses our API or a Denial of Service attack. In such cases, the additional traverses our API or a Denial of Service attack. In such cases, the additional
traffic will reach GitLab Rails and subsequently also other sattelite service. traffic will reach GitLab Rails and subsequently also other satellite services.
Then the sattelite services may need to consult Rails again to obtain new Then the satellite services may need to consult Rails again to obtain new
instructions / policies around rate limiting the increased traffic. This can instructions / policies around rate limiting the increased traffic. This can
put additional strain on Rails application and eventually degrade performance put additional strain on Rails application and eventually degrade performance
even more. In order to avoid this problem, we should extract the API endpoints even more. In order to avoid this problem, we should extract the API endpoints
to separate service (see the section below) if the request rate to those to separate service (see the section below) if the request rate to those
endpoints depends on the volume of incoming traffic. Alternatively we can keep endpoints depends on the volume of incoming traffic. Alternatively we can keep
those endpoints in Rails if the increased traffic will not translate into those endpoints in Rails if the increased traffic will not translate into
increase of requests rate or increas in resources consumption on these API increase of requests rate or increase in resources consumption on these API
endpoints on the Rails side. endpoints on the Rails side.
#### Decoupled Limits Service #### Decoupled Limits Service
...@@ -235,7 +235,7 @@ required, and exposing API, out of Rails. ...@@ -235,7 +235,7 @@ required, and exposing API, out of Rails.
It is impossible to make a decision about extracting such a decoupled limits It is impossible to make a decision about extracting such a decoupled limits
service yet, because we will need to ship more proof-of-concept work, and service yet, because we will need to ship more proof-of-concept work, and
concrete iterations to nform us better about when and how we should do that. We concrete iterations to inform us better about when and how we should do that. We
will depend on the Evolution Architecture practice to guide us towards either will depend on the Evolution Architecture practice to guide us towards either
extracting Decoupled Limits Service or not doing that at all. extracting Decoupled Limits Service or not doing that at all.
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册