Merge branch '417112-remove-ff-zoekt-inde-private-repositories' into 'master'

Remove FF zoekt_index_private_repositories

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/135975



Merged-by: Dmitry Gruzd <dgruzd@gitlab.com>
Approved-by: Dmitry Gruzd <dgruzd@gitlab.com>
Co-authored-by: Changzheng Liu <cliu@gitlab.com>

ee/app/models/ee/project.rb

@@ -946,24 +946,14 @@ def after_import
     def use_zoekt?
       # TODO: rename to index_code_with_zoekt?
       # https://gitlab.com/gitlab-org/gitlab/-/issues/421613
-      return false unless zoekt_indexable?
 
       ::Zoekt::IndexedNamespace.enabled_for_project?(self)
     end
 
     def search_code_with_zoekt?
-      return false unless zoekt_indexable?
-
       ::Zoekt::IndexedNamespace.search_enabled_for_project?(self)
     end
 
-    def zoekt_indexable?
-      return true if self.public? && self.repository_access_level > ::ProjectFeature::PRIVATE
-      return true if ::Feature.enabled?(:zoekt_index_private_repositories)
-
-      false
-    end
-
     def elastic_namespace_ancestry
       namespace.elastic_namespace_ancestry + "p#{id}-"
     end

ee/config/feature_flags/development/zoekt_index_private_repositories.yml

----
-name: zoekt_index_private_repositories
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/125511
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/417112
-milestone: '16.2'
-type: development
-group: group::global search
-default_enabled: true

ee/spec/models/concerns/zoekt/searchable_repository_spec.rb

@@ -25,12 +25,6 @@
       expect(unindexed_repository.use_zoekt?).to eq(false)
     end
 
-    it 'is false for private projects when zoekt_index_private_repositories is disabled' do
-      stub_feature_flags(zoekt_index_private_repositories: false)
-
-      expect(private_repository.use_zoekt?).to eq(false)
-    end
-
     it 'is true for private projects with new indexer' do
       expect(private_repository.use_zoekt?).to eq(true)
     end