Skip to content
代码片段 群组 项目
提交 79c87498 编辑于 作者: James Nutt's avatar James Nutt
浏览文件

Link directly to placeholders tab

This MR updates the `PendingReassignmentAlertPresenter` banner to link
directly to the placeholders tab.

This is to take the user directly to the information the banner informs
them of, and in most cases saves them an extra click.

Related issue: https://gitlab.com/gitlab-org/gitlab/-/issues/495533
上级 18420508
No related branches found
No related tags found
无相关合并请求
...@@ -55,7 +55,7 @@ def group_links ...@@ -55,7 +55,7 @@ def group_links
groups_awaiting_placeholder_assignment.collect do |namespace| groups_awaiting_placeholder_assignment.collect do |namespace|
placeholders << "%{group_#{namespace.id}_link_start}#{namespace.name}%{group_#{namespace.id}_link_end}" placeholders << "%{group_#{namespace.id}_link_start}#{namespace.name}%{group_#{namespace.id}_link_end}"
tag_pairs << tag_pair( tag_pairs << tag_pair(
tag.a(href: group_group_members_path(namespace)), tag.a(href: group_group_members_path(namespace, tab: 'placeholders')),
:"group_#{namespace.id}_link_start", :"group_#{namespace.id}_link_start",
:"group_#{namespace.id}_link_end" :"group_#{namespace.id}_link_end"
) )
......
...@@ -57,7 +57,7 @@ ...@@ -57,7 +57,7 @@
it 'presents the import values' do it 'presents the import values' do
expect(presenter.show_alert?).to eq(true) expect(presenter.show_alert?).to eq(true)
expect(presenter.group_links).to eq("<a href=\"/groups/blink/-/group_members\">blink</a>") expect(presenter.group_links).to eq("<a href=\"/groups/blink/-/group_members?tab=placeholders\">blink</a>")
expect(presenter.groups_awaiting_placeholder_assignment).to match_array(namespaces) expect(presenter.groups_awaiting_placeholder_assignment).to match_array(namespaces)
expect(presenter.group_names).to eq('blink') expect(presenter.group_names).to eq('blink')
expect(presenter.source_hostname).to eq('gitlab.example') expect(presenter.source_hostname).to eq('gitlab.example')
...@@ -86,9 +86,9 @@ ...@@ -86,9 +86,9 @@
it 'presents the import values' do it 'presents the import values' do
expect(presenter.show_alert?).to eq(true) expect(presenter.show_alert?).to eq(true)
expect(presenter.group_links).to eq( expect(presenter.group_links).to eq(
"<a href=\"/groups/blink/-/group_members\">blink</a>, " \ "<a href=\"/groups/blink/-/group_members?tab=placeholders\">blink</a>, " \
"<a href=\"/groups/marquee/-/group_members\">marquee</a>, " \ "<a href=\"/groups/marquee/-/group_members?tab=placeholders\">marquee</a>, " \
"and <a href=\"/groups/details/-/group_members\">details</a>" "and <a href=\"/groups/details/-/group_members?tab=placeholders\">details</a>"
) )
expect(presenter.groups_awaiting_placeholder_assignment).to match_array(namespaces) expect(presenter.groups_awaiting_placeholder_assignment).to match_array(namespaces)
expect(presenter.group_names).to eq('blink, marquee, and details') expect(presenter.group_names).to eq('blink, marquee, and details')
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册