Refactor CI rules entry to use composed value
When we return a value from an entry, we always need to return the composed version. In Rules, we return "config", which means the hash version of what the YAML file has. I changed it to "super" because it needs to have composed value of each sub entry. With this, we also needed to change the validate_against_warnings method. Since we haven't composed the nested entries yet, we cannot use *_value attributes there. These changes are behind a feature flag ci_value_change_for_processable_and_rules_entry
显示
- config/feature_flags/development/ci_value_change_for_processable_and_rules_entry.yml 8 个添加, 0 个删除...pment/ci_value_change_for_processable_and_rules_entry.yml
- lib/gitlab/ci/config/entry/processable.rb 8 个添加, 4 个删除lib/gitlab/ci/config/entry/processable.rb
- lib/gitlab/ci/config/entry/rules.rb 6 个添加, 1 个删除lib/gitlab/ci/config/entry/rules.rb
- spec/lib/gitlab/ci/config/entry/processable_spec.rb 13 个添加, 0 个删除spec/lib/gitlab/ci/config/entry/processable_spec.rb
- spec/lib/gitlab/ci/config/entry/rules_spec.rb 20 个添加, 6 个删除spec/lib/gitlab/ci/config/entry/rules_spec.rb
加载中
想要评论请 注册 或 登录