Merge branch 'filter-external-calls-package-e2e' into 'master'

Filter external calls package e2e

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/127318



Merged-by: Dan Davison <ddavison@gitlab.com>
Approved-by: Dan Davison <ddavison@gitlab.com>
Reviewed-by: Dan Davison <ddavison@gitlab.com>
Co-authored-by: Sofia Vistas <svistas@gitlab.com>

doc/development/testing_guide/end_to_end/rspec_metadata_tests.md

@@ -15,6 +15,7 @@ This is a partial list of the [RSpec metadata](https://rspec.info/features/3-12/
 |-----------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 | `:elasticsearch`            | The test requires an Elasticsearch service. It is used by the [instance-level scenario](https://gitlab.com/gitlab-org/gitlab-qa#definitions) [`Test::Integration::Elasticsearch`](https://gitlab.com/gitlab-org/gitlab/-/blob/72b62b51bdf513e2936301cb6c7c91ec27c35b4d/qa/qa/ee/scenario/test/integration/elasticsearch.rb) to include only tests that require Elasticsearch.                                                                                                                                |
 | `:except`                   | The test is to be run in their typical execution contexts _except_ as specified. See [test execution context selection](execution_context_selection.md) for more information.                                                                                                                                                                                                                                                                                                                                |
+| `:external_api_calls`                   | The test requires interaction with a network external to the Docker network                                                                                                                                                                                                                                                                               |
 | `:feature_flag`             | The test uses a feature flag and therefore requires an administrator account to run. When `scope` is set to `:global`, the test will be skipped on all live .com environments. Otherwise, it will be skipped only on Canary, Production, and Pre-production. See [testing with feature flags](../../../development/testing_guide/end_to_end/feature_flags.md) for more details.                                                                                                                              |
 | `:framework`                | The test makes sanity assertions around the QA framework itself                                                                                                                                                                                                                                                                                                                                                                                                                                              |
 | `:geo`                      | The test requires two GitLab Geo instances - a primary and a secondary - to be spun up.                                                                                                                                                                                                                                                                                                                                                                                                                      |

qa/qa/specs/features/browser_ui/5_package/package_registry/composer_registry_spec.rb

@@ -2,7 +2,7 @@
 
 module QA
   RSpec.describe 'Package', :object_storage, product_group: :package_registry do
-    describe 'Composer Repository' do
+    describe 'Composer Repository', :external_api_calls do
       include Runtime::Fixtures
 
       let(:project) do

qa/qa/specs/features/browser_ui/5_package/package_registry/conan_repository_spec.rb

 # frozen_string_literal: true
 
 module QA
-  RSpec.describe 'Package', :object_storage, product_group: :package_registry, quarantine: {
-    only: { job: %w[object_storage airgapped], condition: -> { QA::Support::FIPS.enabled? } },
+  RSpec.describe 'Package', :object_storage, :external_api_calls, product_group: :package_registry, quarantine: {
+    only: { job: 'object_storage', condition: -> { QA::Support::FIPS.enabled? } },
     issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/417584',
     type: :bug
   } do

qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb

@@ -2,7 +2,7 @@
 
 module QA
   RSpec.describe 'Package', :object_storage, product_group: :package_registry do
-    describe 'Generic Repository', except: { job: 'airgapped' } do
+    describe 'Generic Repository', :external_api_calls do
       include Runtime::Fixtures
 
       let(:project) do

qa/qa/specs/features/browser_ui/5_package/package_registry/helm_registry_spec.rb

@@ -2,7 +2,7 @@
 
 module QA
   RSpec.describe 'Package', :object_storage, product_group: :package_registry do
-    describe 'Helm Registry', except: { job: 'airgapped' } do
+    describe 'Helm Registry', :external_api_calls do
       using RSpec::Parameterized::TableSyntax
       include Runtime::Fixtures
       include Support::Helpers::MaskToken

qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_group_level_spec.rb

@@ -2,7 +2,7 @@
 
 module QA
   RSpec.describe 'Package', :object_storage, product_group: :package_registry do
-    describe 'Maven group level endpoint', except: { job: 'airgapped' } do
+    describe 'Maven group level endpoint', :external_api_calls do
       include Runtime::Fixtures
       include Support::Helpers::MaskToken
       include_context 'packages registry qa scenario'

qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_project_level_spec.rb

 # frozen_string_literal: true
 
 module QA
-  RSpec.describe 'Package', :object_storage, except: { job: 'airgapped' } do
+  RSpec.describe 'Package', :object_storage, :external_api_calls do
     describe 'Maven project level endpoint', product_group: :package_registry do
       include Runtime::Fixtures
       include Support::Helpers::MaskToken

qa/qa/specs/features/browser_ui/5_package/package_registry/maven_gradle_repository_spec.rb

 # frozen_string_literal: true
 
 module QA
-  RSpec.describe 'Package', :object_storage,
+  RSpec.describe 'Package', :object_storage, :external_api_calls,
     quarantine: {
       only: { condition: -> { QA::Support::FIPS.enabled? } },
       issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/417600',

qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_group_level_spec.rb

@@ -2,7 +2,8 @@
 
 module QA
   RSpec.describe 'Package' do
-    describe 'npm Registry group level endpoint', :object_storage, product_group: :package_registry do
+    describe 'npm Registry group level endpoint', :object_storage, :external_api_calls,
+      product_group: :package_registry do
       using RSpec::Parameterized::TableSyntax
       include Runtime::Fixtures
       include Support::Helpers::MaskToken

qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_instance_level_spec.rb

@@ -2,7 +2,8 @@
 
 module QA
   RSpec.describe 'Package' do
-    describe 'npm Registry instance level endpoint', :object_storage, product_group: :package_registry do
+    describe 'npm Registry instance level endpoint', :object_storage, :external_api_calls,
+      product_group: :package_registry do
       using RSpec::Parameterized::TableSyntax
       include Runtime::Fixtures
       include Support::Helpers::MaskToken

qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_project_level_spec.rb

@@ -2,7 +2,8 @@
 
 module QA
   RSpec.describe 'Package' do
-    describe 'npm Registry project level endpoint', :object_storage, product_group: :package_registry do
+    describe 'npm Registry project level endpoint', :object_storage, :external_api_calls,
+      product_group: :package_registry do
       using RSpec::Parameterized::TableSyntax
       include Runtime::Fixtures
       include Support::Helpers::MaskToken

qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb

@@ -2,7 +2,7 @@
 
 module QA
   RSpec.describe 'Package', :object_storage, product_group: :package_registry do
-    describe 'NuGet group level endpoint' do
+    describe 'NuGet group level endpoint', :external_api_calls do
       using RSpec::Parameterized::TableSyntax
       include Runtime::Fixtures
       include Support::Helpers::MaskToken

qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb

@@ -2,7 +2,7 @@
 
 module QA
   RSpec.describe 'Package', :object_storage, product_group: :package_registry do
-    describe 'NuGet project level endpoint' do
+    describe 'NuGet project level endpoint', :external_api_calls do
       include Support::Helpers::MaskToken
 
       let(:project) do

qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb

@@ -2,7 +2,7 @@
 
 module QA
   RSpec.describe 'Package', :object_storage, product_group: :package_registry do
-    describe 'PyPI Repository', except: { job: 'airgapped' } do
+    describe 'PyPI Repository', :external_api_calls do
       include Runtime::Fixtures
       include Support::Helpers::MaskToken
 

qa/qa/specs/features/browser_ui/5_package/package_registry/rubygems_registry_spec.rb

 # frozen_string_literal: true
 
 module QA
-  RSpec.describe 'Package', :object_storage,
+  RSpec.describe 'Package', :object_storage, :external_api_calls,
     feature_flag: { name: 'rubygem_packages', scope: :project } do
     describe 'RubyGems Repository', product_group: :package_registry do
       include Runtime::Fixtures